You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by GitBox <gi...@apache.org> on 2021/06/02 19:15:31 UTC
[GitHub] [db-jdo] clr-apache opened a new pull request #23: Jdo 709 spec
clr-apache opened a new pull request #23:
URL: https://github.com/apache/db-jdo/pull/23
Updated specification changes for final review of JDO-709.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] tzaeschke commented on pull request #23: Jdo 709 spec
Posted by GitBox <gi...@apache.org>.
tzaeschke commented on pull request #23:
URL: https://github.com/apache/db-jdo/pull/23#issuecomment-855284340
Correction: never mind about the empty bullet in Chapter 14, page 15, it does show up in OpenOffice.
I was using LibreOffice which just showed nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] clr-apache merged pull request #23: Jdo 709 spec
Posted by GitBox <gi...@apache.org>.
clr-apache merged pull request #23:
URL: https://github.com/apache/db-jdo/pull/23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] tzaeschke edited a comment on pull request #23: Jdo 709 spec
Posted by GitBox <gi...@apache.org>.
tzaeschke edited a comment on pull request #23:
URL: https://github.com/apache/db-jdo/pull/23#issuecomment-855283591
Some comments:
* Chapter 6: Would it make sense to relabel "Converted Classes" to "Convertible Classes" or "Convertible Types"? In my mind the converted type (a primitive, not a class) is stored in the datastore. The application/domain type is in my mind the un-converted type.
* Chapter 14, page 8: Change "... subsequent execute method" to "subsequent execution" or "subsequently called execute method"?
* ~~Chapter 14, page 15: The last two change just appear to add an empty bullet?~~
* Chapter 19.1.4, page 4: The first line of the javadoc comment is missing a linebreak after `/**`: `/** * The`
* Chapter 19.1.5, page 5: The first line of the javadoc comment is missing a linebreak after `/**`: `/** * The`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo] tzaeschke commented on pull request #23: Jdo 709 spec
Posted by GitBox <gi...@apache.org>.
tzaeschke commented on pull request #23:
URL: https://github.com/apache/db-jdo/pull/23#issuecomment-855283591
Some comments:
* Chapter 6: Would it make sense to relabel "Converted Classes" to "Convertible Classes" or "Convertible Types"? In my mind the converted type (a primitive, not a class) is stored in the datastore. The application/domain type is in my mind the un-converted type.
* Chapter 14, page 8: Change "... subsequent execute method" to "subsequent execution" or "subsequently called execute method"?
* Chapter 14, page 15: The last two change just appear to add an empty bullet?
* Chapter 19.1.4, page 4: The first line of the javadoc comment is missing a linebreak after `/**`: `/** * The`
* Chapter 19.1.5, page 5: The first line of the javadoc comment is missing a linebreak after `/**`: `/** * The`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org