You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Kaijie Chen (Jira)" <ji...@apache.org> on 2021/07/14 08:20:00 UTC

[jira] [Updated] (HDDS-5438) Comment mismatch with code in DatanodeClientProtocol.proto

     [ https://issues.apache.org/jira/browse/HDDS-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kaijie Chen updated HDDS-5438:
------------------------------
    Description: 
There is a comment mismatch with code in DatanodeClientProtocol.proto.

In addition, there is defination of CopyContainer messages in the end of this file which is unused. 
{code:java}
// hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto

// --- Line 75 to 78 ---
 * 17. CloseContainer - Closes an open container and makes it immutable.
 *
 * 18. CopyContainer - Copies a container from a remote machine.
 */

// --- Line 101 to 103 ---
  CloseContainer = 17;
  GetCommittedBlockLength = 18;
}
{code}
[https://github.com/apache/ozone/blob/59e31c4fa59d46412ad05414e6306ff35a3d9b96/hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto#L77]

[https://github.com/apache/ozone/blob/59e31c4fa59d46412ad05414e6306ff35a3d9b96/hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto#L102]

 

  was:
There is a comment mismatch with code in DatanodeClientProtocol.proto.

In addition, there is defination of CopyContainer messages in the end of this file which is unused. 
{code:java}
// hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto

// --- Line 77 ---
 *  18. CopyContainer - Copies a container from a remote machine.

// --- Line 102 ---
  GetCommittedBlockLength = 18;

{code}
[https://github.com/apache/ozone/blob/59e31c4fa59d46412ad05414e6306ff35a3d9b96/hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto#L77]

 

[https://github.com/apache/ozone/blob/59e31c4fa59d46412ad05414e6306ff35a3d9b96/hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto#L102]

 


> Comment mismatch with code in DatanodeClientProtocol.proto  
> ------------------------------------------------------------
>
>                 Key: HDDS-5438
>                 URL: https://issues.apache.org/jira/browse/HDDS-5438
>             Project: Apache Ozone
>          Issue Type: Bug
>            Reporter: Kaijie Chen
>            Priority: Trivial
>
> There is a comment mismatch with code in DatanodeClientProtocol.proto.
> In addition, there is defination of CopyContainer messages in the end of this file which is unused. 
> {code:java}
> // hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto
> // --- Line 75 to 78 ---
>  * 17. CloseContainer - Closes an open container and makes it immutable.
>  *
>  * 18. CopyContainer - Copies a container from a remote machine.
>  */
> // --- Line 101 to 103 ---
>   CloseContainer = 17;
>   GetCommittedBlockLength = 18;
> }
> {code}
> [https://github.com/apache/ozone/blob/59e31c4fa59d46412ad05414e6306ff35a3d9b96/hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto#L77]
> [https://github.com/apache/ozone/blob/59e31c4fa59d46412ad05414e6306ff35a3d9b96/hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto#L102]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org