[GitHub] spark pull request #20327: [SPARK-12963][CORE] NM host for driver end points

[vanzin <gi...@git.apache.org>]

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20327#discussion_r165496876
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -744,7 +744,9 @@ object SparkSubmit extends CommandLineUtils with Logging {
         }
     
         // Ignore invalid spark.driver.host in cluster modes.
    -    if (deployMode == CLUSTER) {
    +    if (isYarnCluster) {
    +      sparkConf.set("spark.driver.host", "${env:NM_HOST}")
    --- End diff --
    
    re: sql, this is not a sql conf object, so sql options have no effect.
    
    I think it would be better to have this in YARN's `Client.scala` instead, in the spirit of not adding more backend-specific logic to this class.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org