You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@aurora.apache.org by "John Sirois (JIRA)" <ji...@apache.org> on 2016/01/26 19:37:39 UTC
[jira] [Commented] (AURORA-1185) immutable thrift definition for
ITaskConfig is missing some functions
[ https://issues.apache.org/jira/browse/AURORA-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117708#comment-15117708 ]
John Sirois commented on AURORA-1185:
-------------------------------------
This part 3 of 3 change to switch java thrift codegen does away with {{I*}} entites altogether: https://reviews.apache.org/r/42756/
> immutable thrift definition for ITaskConfig is missing some functions
> ---------------------------------------------------------------------
>
> Key: AURORA-1185
> URL: https://issues.apache.org/jira/browse/AURORA-1185
> Project: Aurora
> Issue Type: Bug
> Components: Scheduler
> Reporter: Jay Buffington
> Assignee: John Sirois
> Priority: Minor
>
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py doesn't properly handle lines that look like this:
> 29: optional Container container = { "mesos": {} }
> It will ignore any entries after that line. This means that method calls like this will fail to compile
> config = ITaskConfig(...)
> config.getExecutorConfig();
> A work around is to move that line to the end of the struct's definition.
> This was discussed in IRC:
> http://wilderness.apache.org/channels/?f=aurora/2015-03-10#1426012222
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)