You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2010/02/01 17:19:33 UTC

[Bug 6312] [review] uninitialized value $start_time

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6312

Adam Katz <an...@khopis.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |antispam@khopis.com

--- Comment #5 from Adam Katz <an...@khopis.com> 2010-02-01 08:19:29 UTC ---
Yeah, as noted earlier, my perl isn't as hot as some of the other things I do. 
I just find it odd to use a ternary operator with empty clauses, especially if
the empty clause is the first one.  Better to use 'if(!...)' except for the
note below.

Perhaps my assumptions of perl's short-circuiting nature is incorrect, but I
was under the impression something like  'true && false && undef'  wouldn't be
a problem because it would stop everything once you get the false clause.

As to the statement standing within an expression ... again, my green perl
nature shines.  I guess that's why it was ternary, so as to avoid the extra
curly brackets and/or a 'do' stanza?

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.