You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by beargiles <gi...@git.apache.org> on 2015/10/24 18:50:56 UTC
[GitHub] commons-compress pull request: PKZip crypto header extensions
GitHub user beargiles opened a pull request:
https://github.com/apache/commons-compress/pull/3
PKZip crypto header extensions
Addition of five classes that recognize PKZip crypto header extensions. Actual encryption is not supported at this time, this patch is solely so users can identify and ignore otherwise unknown extensions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/beargiles/commons-compress COMPRESS-294
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit dcb5b30c554024455c604a66ed26b62af30d8188
Author: Torsten Curdt <tc...@apache.org>
Date: 2008-10-06T21:49:04Z
switching trunk to redesign branch
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/compress/branches/olddesign@702285 13f79535-47bb-0310-9956-ffa450edef68
commit ee34100e58f8206a7dcd42515b017e74bc665d9c
Author: Stefan Bodewig <bo...@apache.org>
Date: 2009-03-20T12:50:18Z
revert part of the move, need to figure out why only the top level dir was copied first
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/compress/branches/olddesign@756437 13f79535-47bb-0310-9956-ffa450edef68
commit 1501850680e03a385be8dffa3631c9178d7c12dc
Author: Stefan Bodewig <bo...@apache.org>
Date: 2009-03-20T13:14:08Z
copy compress from sandbox to proper
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/olddesign@756443 13f79535-47bb-0310-9956-ffa450edef68
commit b6e0764c3ece41a29de0b4d5779f90ac65af30fd
Author: Stefan Bodewig <bo...@apache.org>
Date: 2011-08-01T03:53:02Z
create a branching point from trunk before merging the ZIP64 branch so that we have a starting point if we want to do a Java 1.4 compatible 1.2.x release
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/commons-compress-1.2.x@1152684 13f79535-47bb-0310-9956-ffa450edef68
commit dd10670b414582d71d55559c8f2bcf02d5a7d543
Author: Stefan Bodewig <bo...@apache.org>
Date: 2013-12-29T06:47:08Z
Branch for Compress 2.0 experiments
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1553997 13f79535-47bb-0310-9956-ffa450edef68
commit 7288ebea6e387d2be4f1d8712e9bcb7756abbf7b
Author: Stefan Bodewig <bo...@apache.org>
Date: 2013-12-30T09:55:11Z
WIP for defining the ArchiveEntry API - need to think about permissions and non-File POSIX stuff
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1554174 13f79535-47bb-0310-9956-ffa450edef68
commit 9c8e266b55558421cb69f1f979459ccb951bf92e
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-07T11:52:20Z
add N&L - the LZMA notice is currently invalid but will need to come back later anyway
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1556190 13f79535-47bb-0310-9956-ffa450edef68
commit 21af9e8a25cea4090d04c7dd34fe98529d75bfef
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-07T12:40:12Z
Initial design idea for IO of archives, absolutely a WIP.
I'll try to port over the AR archiver to see how much effort the
switch from a stream based API to a channel based one would take.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1556196 13f79535-47bb-0310-9956-ffa450edef68
commit a54476642f03d18715150d55f518bbc424e5aa0e
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-07T13:01:58Z
implement equals
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1556201 13f79535-47bb-0310-9956-ffa450edef68
commit 963935d934b874c5482c623ffb87b4ed28d0b47d
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-07T13:02:31Z
porting the ArArchiveEntry is easy - as expected
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1556202 13f79535-47bb-0310-9956-ffa450edef68
commit 7af33ebd3a8519bb749023b64f707f0753086cbe
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-07T13:37:45Z
Output seems to relatively straight forward to port. No tests, though.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1556213 13f79535-47bb-0310-9956-ffa450edef68
commit 4b16f5e32fbfe6cdfbecd9792c07d7645f1683c4
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-07T17:31:27Z
implement input, this compiles but I'm not sure it works - tests are up next
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1556286 13f79535-47bb-0310-9956-ffa450edef68
commit 999fb5f2fe5f974cd76a18b4e0c873022f51e700
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-07T17:59:15Z
AR stores date as seconds since epoch
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1556293 13f79535-47bb-0310-9956-ffa450edef68
commit ed7ec468f5e7a74cf3b9f7c42bf0c62eaa2fd3e2
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-07T18:48:56Z
deal with missing owner information
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1556311 13f79535-47bb-0310-9956-ffa450edef68
commit 3700530dd90fde8ed39299d5f715d3dcf043ff33
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-07T18:50:04Z
add an incomplete testcase - it isn't testing much but I've manually verified the archive is valid and the extracted files are correct
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1556312 13f79535-47bb-0310-9956-ffa450edef68
commit 1f9eff23dd3ee806f42d33fd3a8ad69142b3ce2e
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-08T12:38:57Z
Random access archive input similar to what ZipFile provides
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1556516 13f79535-47bb-0310-9956-ffa450edef68
commit 992ee5685977a7675f97053914c8e1861ab2427b
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-08T12:55:56Z
note to self
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1556518 13f79535-47bb-0310-9956-ffa450edef68
commit f51552902223e2b7ba2517e51e7cd0883c1ef47b
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-08T12:56:37Z
Archive(In|Out)put isn't really a Channel itself
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1556519 13f79535-47bb-0310-9956-ffa450edef68
commit 2f0a1ad1e165b3bf410538fd647dd508b1897ea0
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-08T12:58:34Z
putEntry closes the previous entry, why shouldn't finish do so as well?
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1556521 13f79535-47bb-0310-9956-ffa450edef68
commit 5de3b4f79f9f03b5aba8f912637139bcdcc10456
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-08T15:40:32Z
they are no channels (anymore)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1556559 13f79535-47bb-0310-9956-ffa450edef68
commit 7bcfee5a0caa4c09af604eb583c3bf54e8153674
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-17T12:54:41Z
first cut a self-describing archive formats
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1559094 13f79535-47bb-0310-9956-ffa450edef68
commit 9ef58d2ae275c5b1d51e286dc5acf4f065e5af37
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-19T06:30:31Z
ArchiveInput/Output is parameterized, so must be ArchiveFormat
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1559476 13f79535-47bb-0310-9956-ffa450edef68
commit ac5b137b67c15e3814b2b1a6e18ac89a1a14872c
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-19T06:49:22Z
must be more specific about the direction of channels
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1559477 13f79535-47bb-0310-9956-ffa450edef68
commit 0bf6a88e5039cfda0fccbf0d86df3424e5141af9
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-19T07:03:40Z
implement ArchiveFormat for AR
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1559479 13f79535-47bb-0310-9956-ffa450edef68
commit cd8337ca5cd6c4b833a79a010d38b66ddddc3aab
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-19T13:42:39Z
some more tests to provide more coverage of the abstract ArchiveFormat - tests are in need of some DRYing up, I know
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1559497 13f79535-47bb-0310-9956-ffa450edef68
commit a439f83449df9ba413efd6ed46263a09de60f270
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-24T17:44:35Z
discover archive formats via ServiceLoader
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1561086 13f79535-47bb-0310-9956-ffa450edef68
commit 04673b6a801ed5c66465996cf77dc32487846c50
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-25T06:22:39Z
the list of formats to consult first may be too much - let's keep the implementations independent of each other
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1561264 13f79535-47bb-0310-9956-ffa450edef68
commit 1336cebfd8d644cc534c525644a27f2e2cb560be
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-01-25T06:46:10Z
internally sort archives found in a way that during auto-detection the formats requiring less bytes come first
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1561268 13f79535-47bb-0310-9956-ffa450edef68
commit 84d92916b9fead62bbe7c3120d480c3a82f40f31
Author: Stefan Bodewig <bo...@apache.org>
Date: 2014-04-27T16:10:08Z
Compress2 will require Java7
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/branches/compress-2.0@1590412 13f79535-47bb-0310-9956-ffa450edef68
commit 9067b02c65bf4316e0541579bdb883c6d3d07852
Author: Kristian Rosenvold <kr...@apache.org>
Date: 2014-12-18T20:51:57Z
COMPRESS-295 Add support for transferring a zip entry from one zip file to another
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/trunk@1646531 13f79535-47bb-0310-9956-ffa450edef68
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress pull request: PKZip crypto header extensions
Posted by beargiles <gi...@git.apache.org>.
Github user beargiles commented on the pull request:
https://github.com/apache/commons-compress/pull/3#issuecomment-151670553
Let me know what you need me to do. I've never done branching and merging with git before, much less across projects, so I'm pretty much fumbling at this point.
It looks like the first step is closing this pull request and waiting for you to merge/change default branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress pull request: PKZip crypto header extensions
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the pull request:
https://github.com/apache/commons-compress/pull/3#issuecomment-151607463
Oops, this looks bigger than intended :-)
It seems as if out migration to git has made the wrong branch the default branch. I'll ask the ASF infra team to fix it. After that, please re-create the PR against the master branch.
Also, I'll try to get in touch with the PKWare folks, just to be safe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress pull request: PKZip crypto header extensions
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the pull request:
https://github.com/apache/commons-compress/pull/3#issuecomment-151728703
Don't feel forced to create a pull request just because we are using git now. The established workflow of attaching a patch to JIRA is still in place. Whatever is more convenient to you.
This repo's default branch is master now, so a fresh github clone would be based on the correct branch.
Within the existing clone you can add a master branch that tracks our master
```
git checkout -b master remotes/apache/master
git push origin master -u
```
this is assuming you have a remote named apache defined for our git repository and origin for your github clone of it.
There are several ways you can try to merge your changes to the new master branch. This ranges from simply copying over the code (the low tech version, that always works) to `cherry-pick`ing the commits from the COMPRESS-294 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress pull request: PKZip crypto header extensions
Posted by beargiles <gi...@git.apache.org>.
Github user beargiles closed the pull request at:
https://github.com/apache/commons-compress/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org