You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/09 16:19:11 UTC
[GitHub] [spark] gaborgsomogyi opened a new pull request #29989: [SPARK-33102][SQL] Use stringToSeq on SQL list typed parameters
gaborgsomogyi opened a new pull request #29989:
URL: https://github.com/apache/spark/pull/29989
### What changes were proposed in this pull request?
While I've implemented JDBC provider disable functionality it has been popped up [here](https://github.com/apache/spark/pull/29964#discussion_r501786746) that `Utils.stringToSeq` must be used when String list type SQL parameter handled. In this PR I've fixed the problematic parameters.
### Why are the changes needed?
`Utils.stringToSeq` must be used when String list type SQL parameter handled.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29989: [SPARK-33102][SQL] Use stringToSeq on SQL list typed parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29989:
URL: https://github.com/apache/spark/pull/29989#issuecomment-706393962
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #29989: [SPARK-33102][SQL] Use stringToSeq on SQL list typed parameters
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29989:
URL: https://github.com/apache/spark/pull/29989
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29989: [SPARK-33102][SQL] Use stringToSeq on SQL list typed parameters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29989:
URL: https://github.com/apache/spark/pull/29989#issuecomment-706298327
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34193/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29989: [SPARK-33102][SQL] Use stringToSeq on SQL list typed parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29989:
URL: https://github.com/apache/spark/pull/29989#issuecomment-706308994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29989: [SPARK-33102][SQL] Use stringToSeq on SQL list typed parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29989:
URL: https://github.com/apache/spark/pull/29989#issuecomment-706393962
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29989: [SPARK-33102][SQL] Use stringToSeq on SQL list typed parameters
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29989:
URL: https://github.com/apache/spark/pull/29989#issuecomment-706275379
**[Test build #129589 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129589/testReport)** for PR 29989 at commit [`54d9118`](https://github.com/apache/spark/commit/54d91183d948b3d1b66ed9650a6e1a0993861085).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on pull request #29989: [SPARK-33102][SQL] Use stringToSeq on SQL list typed parameters
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #29989:
URL: https://github.com/apache/spark/pull/29989#issuecomment-706561884
Thanks you guys, just wanted to CC somebody :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29989: [SPARK-33102][SQL] Use stringToSeq on SQL list typed parameters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29989:
URL: https://github.com/apache/spark/pull/29989#issuecomment-706308914
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34193/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29989: [SPARK-33102][SQL] Use stringToSeq on SQL list typed parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29989:
URL: https://github.com/apache/spark/pull/29989#issuecomment-706309020
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34193/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29989: [SPARK-33102][SQL] Use stringToSeq on SQL list typed parameters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29989:
URL: https://github.com/apache/spark/pull/29989#issuecomment-706275379
**[Test build #129589 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129589/testReport)** for PR 29989 at commit [`54d9118`](https://github.com/apache/spark/commit/54d91183d948b3d1b66ed9650a6e1a0993861085).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29989: [SPARK-33102][SQL] Use stringToSeq on SQL list typed parameters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29989:
URL: https://github.com/apache/spark/pull/29989#issuecomment-706308994
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29989: [SPARK-33102][SQL] Use stringToSeq on SQL list typed parameters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29989:
URL: https://github.com/apache/spark/pull/29989#issuecomment-706392813
**[Test build #129589 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129589/testReport)** for PR 29989 at commit [`54d9118`](https://github.com/apache/spark/commit/54d91183d948b3d1b66ed9650a6e1a0993861085).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29989: [SPARK-33102][SQL] Use stringToSeq on SQL list typed parameters
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29989:
URL: https://github.com/apache/spark/pull/29989#issuecomment-706487515
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org