You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Rabi Kumar K C (Jira)" <ji...@apache.org> on 2020/03/18 17:28:00 UTC

[jira] [Comment Edited] (SOLR-13768) Remove support for deprecated 'requireSub' parameter in JWTAuthPlugin

    [ https://issues.apache.org/jira/browse/SOLR-13768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061890#comment-17061890 ] 

Rabi Kumar K C edited comment on SOLR-13768 at 3/18/20, 5:27 PM:
-----------------------------------------------------------------

Hi [~janhoy] I was just going through JWTAuthPlugin class and it seems that PARAM_REQUIRE_SUBJECT is not marked as deprecated but if the value is set then message at warning level is logged saying that param_require_subject might be removed in the future releases. I have removed this parameter and created a PR for this. Please do let me know if the made changes are not the expected one so that I could make the correct changes.


was (Author: rabikumar.kc):
Hi [~janhoy] I was just going through JWTAuthPlugin class and it seems that PARAM_REQUIRE_SUBJECT is not marked as deprecated but if the value is set then message at warning level is logged saying that param_require_subject might be removed in the future releases. I have removed this parameter and created a PR fo this. Please do let me know if the made changes are not the expected one so that I could make the correct changes.

> Remove support for deprecated 'requireSub' parameter in JWTAuthPlugin
> ---------------------------------------------------------------------
>
>                 Key: SOLR-13768
>                 URL: https://issues.apache.org/jira/browse/SOLR-13768
>             Project: Solr
>          Issue Type: Improvement
>          Components: Authentication
>            Reporter: Jan Høydahl
>            Priority: Major
>             Fix For: master (9.0)
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Spinoff from SOLR-13734



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org