[jira] Commented: (QPID-1408) Managementgen C++ code gets compile errors on Windows

["Ted Ross (JIRA)" <qp...@incubator.apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643350#action_12643350 ] 

Ted Ross commented on QPID-1408:
--------------------------------

Steve,

This looks good.  Ok to commit.

Thanks,

-Ted


> Managementgen C++ code gets compile errors on Windows
> -----------------------------------------------------
>
>                 Key: QPID-1408
>                 URL: https://issues.apache.org/jira/browse/QPID-1408
>             Project: Qpid
>          Issue Type: Bug
>          Components: Code Generator
>         Environment: Windows, Visual Studio .NET 2005
>            Reporter: Steve Huston
>             Fix For: M4
>
>         Attachments: schema.diff
>
>
> The managementgen-generated schema code gets compile errors on Windows because part of the Windows system header files defines OPTIONAL and that token is also used as a string name in generated code. The attached patch changes the generated OPTIONAL to IS_OPTIONAL to resolve this. It also changes INDEX to IS_INDEX just to keep it consistent with OPTIONAL.
> Please review and let me know if it's ok to commit this.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.