[GitHub] incubator-metron pull request #222: METRON-385 Create Ambari Service Definit...

[nickwallen <gi...@git.apache.org>]

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/222#discussion_r77627924
  
    --- Diff: metron-deployment/packaging/ambari/src/main/resources/common-services/INDEXING/0.2.0BETA/service_advisor.py ---
    @@ -0,0 +1,65 @@
    +#!/usr/bin/env ambari-python-wrap
    +"""
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +    http://www.apache.org/licenses/LICENSE-2.0
    +Unless required by applicable law or agreed to in writing, software
    +distributed under the License is distributed on an "AS IS" BASIS,
    +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +See the License for the specific language governing permissions and
    +limitations under the License.
    +"""
    +import imp
    +import os
    +import traceback
    +
    +SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
    +STACKS_DIR = os.path.join(SCRIPT_DIR, '../../../stacks/')
    +PARENT_FILE = os.path.join(STACKS_DIR, 'service_advisor.py')
    +
    +try:
    +    with open(PARENT_FILE, 'rb') as fp:
    +        service_advisor = imp.load_module('service_advisor', fp, PARENT_FILE, ('.py', 'rb', imp.PY_SOURCE))
    +except Exception as e:
    +    traceback.print_exc()
    +    print("Failed to load parent service_advisor file '{}'".format(PARENT_FILE))
    +
    +
    +class INDEXING020BETAServiceAdvisor(service_advisor.ServiceAdvisor):
    --- End diff --
    
    The Metron version is embedded in this class name.  Also, the path for the Indexing `metron-deployment/packaging/ambari/src/main/resources/common-services/INDEXING/0.2.0BETA/...` includes the Metron version.  
    
    How will we handle this when we bump Metron versions?  Is there no better way to handle this?  I know we have to play within the sandbox provided by Ambari.  Is this an Ambari-imposed pain point?
    
    Everything else looks great BTW.  Very easy to read code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---