You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2011/09/13 12:04:09 UTC
[jira] [Reopened] (HBASE-4384) Hard to tell what causes failure in
ZKAssign#createNodeClosing
[ https://issues.apache.org/jira/browse/HBASE-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J reopened HBASE-4384:
----------------------------
Mehh... Confusions.
> Hard to tell what causes failure in ZKAssign#createNodeClosing
> --------------------------------------------------------------
>
> Key: HBASE-4384
> URL: https://issues.apache.org/jira/browse/HBASE-4384
> Project: HBase
> Issue Type: Task
> Components: zookeeper
> Affects Versions: 0.90.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 0.94.0
>
>
> The current code goes like:
> {code}
> 467 public static int createNodeClosing(ZooKeeperWatcher zkw, HRegionInfo region,
> 468 String serverName)
> 469 throws KeeperException, KeeperException.NodeExistsException {
> 470 LOG.debug(zkw.prefix("Creating unassigned node for " +
> 471 region.getEncodedName() + " in a CLOSING state"));
> 472
> 473 RegionTransitionData data = new RegionTransitionData(
> 474 EventType.RS_ZK_REGION_CLOSING, region.getRegionName(), serverName);
> 475
> 476 synchronized (zkw.getNodes()) {
> 477 String node = getNodeName(zkw, region.getEncodedName());
> 478 zkw.getNodes().add(node);
> 479 return ZKUtil.createAndWatch(zkw, node, data.getBytes());
> 480 }
> 481 }
> {code}
> Both WARN cases would be identical this way. In case of an exception, I think an exception ought to be logged as well.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira