Re: [PR] feat(devicectl): Use devicectl for deploying to devices [cordova-ios]

["GitToTheHub (via GitHub)" <gi...@apache.org>]

GitToTheHub commented on PR #1636:
URL: https://github.com/apache/cordova-ios/pull/1636#issuecomment-6080149214

   Hi @dpogue.
   
   I’ve added 38 unit tests covering the `run.js` deployment changes, plus fixes for regressions exposed by those tests:
   https://github.com/GitToTheHub/cordova-ios/commit/aa2d1e44173db116c3d0ad53b2bd923238de3aec
   
   This is based on your current PR head. Lint and all 364 Jasmine tests pass, and 77 native simulator tests pass.
   
   Xcode 27 required an external deployment-target override, because this PR is not synced with the master.
   
   I also tested installation, launch, and deviceready on a USB-connected iPhone 11 running iOS 27.0.1, using both automatic selection and an explicit target. Simulator deployment also succeeded.
   
   Physical testing of the ios-deploy fallback on iOS below 17 remains outstanding.
   
   Would you prefer to cherry-pick this commit, or should I open a PR against your devicectl branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org