You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/08 11:01:02 UTC
[GitHub] [dolphinscheduler] jluckie opened a new issue, #13136: [Bug] [task-sql] ParameterUtils.expandListParameter get a null pointer exception
jluckie opened a new issue, #13136:
URL: https://github.com/apache/dolphinscheduler/issues/13136
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
[ERROR] 2022-12-08 09:30:30.645 +0000 - sql task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.plugin.task.api.parser.ParameterUtils.expandListParameter(ParameterUtils.java:170)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.getSqlAndSqlParamsMap(SqlTask.java:457)
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1382)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:566)
at org.apache.dolphinscheduler.plugin.task.sql.SqlTask.handle(SqlTask.java:142)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:208)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
### What you expected to happen
When I upgraded from version 3.0.0 to 3.0.2, the execution task got null pointer exception.
It was normal before I upgraded and I observed that ParameterUtils.expandListParameter is a recent addition to the code.
### How to reproduce
By reading the dolphinscheduler source code, I found the following code.
```java
String[] split = sql.split("\\?");
...
for (int i = 1; i < split.length; i++) {
Property property = params.get(i);
String value = property.getValue();
}
```
The placeholder for the parameter is "?" and if the "?" is also present in my sql If my sql also has "?" in it, for example in a regular expression, will that lead to an error in splitting and guessing the wrong number of parameters, leading to an out-of-bounds index from the map and a null result.
### Anything else
_No response_
### Version
3.0.x
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13136: [Bug] [task-sql] ParameterUtils.expandListParameter get a null pointer exception
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13136:
URL: https://github.com/apache/dolphinscheduler/issues/13136#issuecomment-1430570434
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] jluckie commented on issue #13136: [Bug] [task-sql] ParameterUtils.expandListParameter get a null pointer exception
Posted by GitBox <gi...@apache.org>.
jluckie commented on issue #13136:
URL: https://github.com/apache/dolphinscheduler/issues/13136#issuecomment-1374495674
>
Yes, I repaired and test ok, will post a pull request later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13136: [Bug] [task-sql] ParameterUtils.expandListParameter get a null pointer exception
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13136:
URL: https://github.com/apache/dolphinscheduler/issues/13136#issuecomment-1419982475
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #13136: [Bug] [task-sql] ParameterUtils.expandListParameter get a null pointer exception
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #13136: [Bug] [task-sql] ParameterUtils.expandListParameter get a null pointer exception
URL: https://github.com/apache/dolphinscheduler/issues/13136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #13136: [Bug] [task-sql] ParameterUtils.expandListParameter get a null pointer exception
Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie commented on issue #13136:
URL: https://github.com/apache/dolphinscheduler/issues/13136#issuecomment-1489774931
reopen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] jluckie commented on issue #13136: [Bug] [task-sql] ParameterUtils.expandListParameter get a null pointer exception
Posted by GitBox <gi...@apache.org>.
jluckie commented on issue #13136:
URL: https://github.com/apache/dolphinscheduler/issues/13136#issuecomment-1342940201
> Can you fix it?
The above is just my guess, I will test and reproduce it, I think I can fix it, it will take a little time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13136: [Bug] [task-sql] ParameterUtils.expandListParameter get a null pointer exception
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13136:
URL: https://github.com/apache/dolphinscheduler/issues/13136#issuecomment-1558260221
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #13136: [Bug] [task-sql] ParameterUtils.expandListParameter get a null pointer exception
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #13136: [Bug] [task-sql] ParameterUtils.expandListParameter get a null pointer exception
URL: https://github.com/apache/dolphinscheduler/issues/13136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13136: [Bug] [task-sql] ParameterUtils.expandListParameter get a null pointer exception
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13136:
URL: https://github.com/apache/dolphinscheduler/issues/13136#issuecomment-1548788218
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ChPi commented on issue #13136: [Bug] [task-sql] ParameterUtils.expandListParameter get a null pointer exception
Posted by GitBox <gi...@apache.org>.
ChPi commented on issue #13136:
URL: https://github.com/apache/dolphinscheduler/issues/13136#issuecomment-1370436514
Has there been any progress？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] davidzollo commented on issue #13136: [Bug] [task-sql] ParameterUtils.expandListParameter get a null pointer exception
Posted by GitBox <gi...@apache.org>.
davidzollo commented on issue #13136:
URL: https://github.com/apache/dolphinscheduler/issues/13136#issuecomment-1342901297
Can you fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13136: [Bug] [task-sql] ParameterUtils.expandListParameter get a null pointer exception
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #13136:
URL: https://github.com/apache/dolphinscheduler/issues/13136#issuecomment-1342536820
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org