You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/03 16:14:29 UTC

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9210: Add maximize and minimize feature to charts

etr2460 commented on a change in pull request #9210: Add maximize and minimize feature to charts
URL: https://github.com/apache/incubator-superset/pull/9210#discussion_r387126405
 
 

 ##########
 File path: superset-frontend/src/dashboard/components/SliceHeader.jsx
 ##########
 @@ -46,6 +46,8 @@ const propTypes = {
   componentId: PropTypes.string.isRequired,
   filters: PropTypes.object.isRequired,
   addDangerToast: PropTypes.func.isRequired,
+  handleFullSize: PropTypes.func.isRequired,
+  resizeEvent: PropTypes.bool,
 
 Review comment:
   if this is a boolean, then it should be probably named something like `isResizeEvent` or `hasResizeEvent`. I'm not quite sure what makes the most sense here, but some renaming would be great

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org