You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Eugene Koontz (JIRA)" <ji...@apache.org> on 2012/08/07 21:00:21 UTC
[jira] [Commented] (GIRAPH-288) Bandwidth tracking - subset of
GIRAPH-262
[ https://issues.apache.org/jira/browse/GIRAPH-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430528#comment-13430528 ]
Eugene Koontz commented on GIRAPH-288:
--------------------------------------
Looks good except:
{code}
- Executors.newCachedThreadPool()));
+ Executors.newCachedThreadPool(),
+ conf.getInt(GiraphJob.MSG_NUM_FLUSH_THREADS,
+ NettyServer.DEFAULT_MAXIMUM_THREAD_POOL_SIZE)));
{code}
{code}
M extends Writable> {
/** Default maximum thread pool size */
- public static final int DEFAULT_MAXIMUM_THREAD_POOL_SIZE = 64;
+ public static final int DEFAULT_MAXIMUM_THREAD_POOL_SIZE = 32;
{code}
{code}
- try {
- workerThreadPool =
- (ThreadPoolExecutor) Executors.newCachedThreadPool(workerFactory);
- workerThreadPool.setMaximumPoolSize(maximumPoolSize);
- } catch (ClassCastException e) {
- LOG.warn("Netty worker thread pool is not of type ThreadPoolExecutor", e);
- }
+ Executors.newCachedThreadPool(workerFactory);
+
channelFactory = new NioServerSocketChannelFactory(
Executors.newCachedThreadPool(bossFactory),
- workerThreadPool);
+ Executors.newCachedThreadPool(workerFactory),
+ maximumPoolSize);
{code}
can be removed from this patch because they are part of GIRAPH-289.
> Bandwidth tracking - subset of GIRAPH-262
> -----------------------------------------
>
> Key: GIRAPH-288
> URL: https://issues.apache.org/jira/browse/GIRAPH-288
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-288.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira