[GitHub] phoenix pull request #192: Phoenix Cursors implementation

[ankitsinghal <gi...@git.apache.org>]

Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/192#discussion_r77612036
  
    --- Diff: phoenix-core/src/main/antlr3/PhoenixSQL.g ---
    @@ -726,8 +727,11 @@ upsert_column_refs returns [Pair<List<ColumnDef>,List<ColumnName>> ret]
     
     // Parse a full declare cursor expression structure.
     declare_cursor_node returns [DeclareCursorStatement ret]
    -    :    DECLARE c=cursor_name CURSOR FOR s=select_node
    -        {ret = factory.declareCursor(c, s); }
    +@init{boolean isStatic = false;}
    +    :   DECLARE c=cursor_name CURSOR
    +        (STATIC {isStatic = true;})?
    --- End diff --
    
    here it can be replaced with, (static=STATIC)? and use factory.declareCursor(c,s static!=null)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---