[GitHub] erisu opened a new pull request #406: Added Back Missing unorm Dependency

[GitBox <gi...@apache.org>]

erisu opened a new pull request #406: Added Back Missing unorm Dependency
URL: https://github.com/apache/cordova-ios/pull/406
 
 
   ### Platforms affected
   ios
   
   ### What does this PR do?
   The goal of this PR is to re-add the missing dependency so cordova-ios does not fail with cordova-common master.
   
   cordova-common use to have a dependency called unorm. This dependency was not being used in cordova-common so I suspect it was removed.
   
   https://github.com/apache/cordova-common/commit/d473b190960ae3401ede0993994220c89d262bc0#diff-b9cfc7f2cdf78a7f4b91a753d10865a2
   
   This dependency, on the other hand, was being used in cordova-ios.
   
   https://github.com/apache/cordova-ios/blob/ff1bcd05f419cd0a8a12006c9d512ef5c92b510f/bin/templates/scripts/cordova/Api.js#L24
   
   https://github.com/apache/cordova-ios/blob/ff1bcd05f419cd0a8a12006c9d512ef5c92b510f/bin/templates/scripts/cordova/lib/prepare.js#L26
   
   Previously, unorm use to to be a commited node_module for cordova-ios repo. Once the commited node_modules were removed, both cordova-ios and cordova-common on master branch was missing this dependency.
   
   If you clone cordova-ios master, run npm install, and then run the tests for ios, it does not fail is because cordova-ios package.json is configured to use cordova-common@2.1.0 which has unorm. To reproduce, make sure to also update cordova-common to point to master.
   
   ### What testing has been done on this change?
   - `npm run`
   
   Test failures may appear when running against cordova-common@master. This is not related to adding unorm. I had also tested using the older version of unorm@1.3.3, which is identical to what has been committed into the repo previously.
   
   Those issues will need to be invested and fixed in a separate PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org