You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/09 18:11:43 UTC
[GitHub] [airflow] yehoshuadimarsky opened a new pull request #20775: support IAM login for gcp sql with proxy
yehoshuadimarsky opened a new pull request #20775:
URL: https://github.com/apache/airflow/pull/20775
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: #20660
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yehoshuadimarsky commented on pull request #20775: support IAM login for gcp sql with proxy
Posted by GitBox <gi...@apache.org>.
yehoshuadimarsky commented on pull request #20775:
URL: https://github.com/apache/airflow/pull/20775#issuecomment-1008348390
See this link for details about IAM login with Google SQL Cloud Auth proxy: https://cloud.google.com/sql/docs/postgres/iam-logins#cloud-sql-auth-proxy
But I can't figure out how to test this kind of login within old-style `unittest` patching - any suggestions?
Relevant parts of existing test code:
https://github.com/apache/airflow/blob/68fa358c85d0ebe1aa22ace30b33867ad4e622a8/tests/providers/google/cloud/hooks/test_cloud_sql.py#L989-L1038
and
https://github.com/apache/airflow/blob/68fa358c85d0ebe1aa22ace30b33867ad4e622a8/tests/providers/google/cloud/hooks/test_cloud_sql.py#L1122-L1135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yehoshuadimarsky commented on pull request #20775: support IAM login for gcp sql with proxy
Posted by GitBox <gi...@apache.org>.
yehoshuadimarsky commented on pull request #20775:
URL: https://github.com/apache/airflow/pull/20775#issuecomment-1050507770
Closing PR, as I don't have time to implement this, and my use case for this was solved by a workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20775: support IAM login for gcp sql with proxy
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20775:
URL: https://github.com/apache/airflow/pull/20775#issuecomment-1050381513
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20775: support IAM login for gcp sql with proxy
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20775:
URL: https://github.com/apache/airflow/pull/20775#issuecomment-1009289450
What's the problem with unit testing ? seems that the unit tests are failing and needs just fixing :)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yehoshuadimarsky closed pull request #20775: support IAM login for gcp sql with proxy
Posted by GitBox <gi...@apache.org>.
yehoshuadimarsky closed pull request #20775:
URL: https://github.com/apache/airflow/pull/20775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org