You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/12/15 00:47:12 UTC
Re: Review Request 41166: Logger Module: Explicitly disallow use of
the ContainerLogger with the External Containerizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41166/
-----------------------------------------------------------
(Updated Dec. 14, 2015, 3:47 p.m.)
Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
Changes
-------
Migrate initialization of the ContainerLogger into the Containerizer itself.
Summary (updated)
-----------------
Logger Module: Explicitly disallow use of the ContainerLogger with the External Containerizer.
Bugs: MESOS-4088
https://issues.apache.org/jira/browse/MESOS-4088
Repository: mesos
Description (updated)
-------
Using the `ContainerLogger` with the `ExternalContainerizer` is not supported at the moment. We explicitly disallowed the combination, so that there are no incorrect assumptions.
Diffs (updated)
-----
src/slave/containerizer/containerizer.cpp dcdf98fea4ca6f96658886db5d09c99f3bff501d
Diff: https://reviews.apache.org/r/41166/diff/
Testing
-------
This is tested later in the review chain.
Thanks,
Joseph Wu
Re: Review Request 41166: Logger Module: Explicitly disallow use of
the ContainerLogger with the External Containerizer.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41166/#review111423
-----------------------------------------------------------
Ship it!
src/slave/containerizer/containerizer.cpp (line 174)
<https://reviews.apache.org/r/41166/#comment171600>
Suggestion to make things even more explicit:
---
The external containerizer does not support custom container logger modules, i.e., you can't set both the '--isolation=external' and '--container_logger=...' flags.
---
Same below as well (but slightly different flags).
- Benjamin Hindman
On Dec. 14, 2015, 11:47 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41166/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 11:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
>
>
> Bugs: MESOS-4088
> https://issues.apache.org/jira/browse/MESOS-4088
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Using the `ContainerLogger` with the `ExternalContainerizer` is not supported at the moment. We explicitly disallowed the combination, so that there are no incorrect assumptions.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp dcdf98fea4ca6f96658886db5d09c99f3bff501d
>
> Diff: https://reviews.apache.org/r/41166/diff/
>
>
> Testing
> -------
>
> This is tested later in the review chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 41166: Logger Module: Explicitly disallow use of
the ContainerLogger with the External Containerizer.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41166/
-----------------------------------------------------------
(Updated Dec. 21, 2015, 11:37 a.m.)
Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
Changes
-------
Reworded error message.
Bugs: MESOS-4088
https://issues.apache.org/jira/browse/MESOS-4088
Repository: mesos
Description
-------
Using the `ContainerLogger` with the `ExternalContainerizer` is not supported at the moment. We explicitly disallowed the combination, so that there are no incorrect assumptions.
Diffs (updated)
-----
src/slave/containerizer/containerizer.cpp dcdf98fea4ca6f96658886db5d09c99f3bff501d
Diff: https://reviews.apache.org/r/41166/diff/
Testing
-------
This is tested later in the review chain.
Thanks,
Joseph Wu