You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by AyolaJayamaha <gi...@git.apache.org> on 2015/08/20 17:22:51 UTC

[GitHub] phoenix pull request: PHOENIX-2187: Adding front-end of Tracing We...

GitHub user AyolaJayamaha opened a pull request:

    https://github.com/apache/phoenix/pull/112

    PHOENIX-2187: Adding front-end of Tracing Web App

    This will include the followingTracing visualization features.
    - [x] List - lists the traces with their attributes
    - [x] Trace Count - Chart view over the trace description
    - [x] Dependency Tree - tree view of trace ids
    - [x] Timeline - timeline of trace ids
    - [x] Trace Distribution - Distribution chart of hosts of traces

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AyolaJayamaha/phoenix front-end-webapp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #112
    
----
commit 7f78b5508f782196a97c4f876987e6cdaf573477
Author: ayolajayamaha <ra...@gmail.com>
Date:   2015-08-20T15:17:34Z

    adding front-end of trace web app

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] phoenix pull request: PHOENIX-2187: Adding front-end of Tracing We...

Posted by AyolaJayamaha <gi...@git.apache.org>.
Github user AyolaJayamaha commented on the pull request:

    https://github.com/apache/phoenix/pull/112#issuecomment-133054413
  
    Build phoenix-tracing-webapp by
    `mvn package`
    It will run jasmine JS Test Specs with testing JS files in Tracing Web app
    
    ![screenshot from 2015-08-20 21 05 31](https://cloud.githubusercontent.com/assets/1260234/9387657/3bf6401c-477f-11e5-9d8e-78af949f6723.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] phoenix pull request: PHOENIX-2187: Adding front-end of Tracing We...

Posted by ndimiduk <gi...@git.apache.org>.
Github user ndimiduk commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/112#discussion_r37574069
  
    --- Diff: phoenix-tracing-webapp/src/build/build.xml ---
    @@ -0,0 +1,40 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +  <project name="trace-webapp-demo" default="war" basedir=".">
    +
    +    <property name="project-name" value="${ant.project.name}" />
    +    <property name="builder" value="ayola" />
    +
    +    <property name="war-file-name" value="${project-name}.war" />
    +    <property name="webapp-directory" value="src/main/webapp" />
    +    <property name="classes-directory" value="src/main/webapp" />
    --- End diff --
    
    this is provided in the other PR, right? no need to include it here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] phoenix pull request: PHOENIX-2187: Adding front-end of Tracing We...

Posted by ndimiduk <gi...@git.apache.org>.
Github user ndimiduk commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/112#discussion_r37573877
  
    --- Diff: phoenix-tracing-webapp/pom.xml ---
    @@ -0,0 +1,171 @@
    +<?xml version='1.0'?>
    +  <!--
    +
    + Licensed to the Apache Software Foundation (ASF) under one
    + or more contributor license agreements.  See the NOTICE file
    + distributed with this work for additional information
    + regarding copyright ownership.  The ASF licenses this file
    + to you under the Apache License, Version 2.0 (the
    + "License"); you may not use this file except in compliance
    + with the License.  You may obtain a copy of the License at
    +
    +   http://www.apache.org/licenses/LICENSE-2.0
    +
    + Unless required by applicable law or agreed to in writing,
    + software distributed under the License is distributed on an
    + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + KIND, either express or implied.  See the License for the
    + specific language governing permissions and limitations
    + under the License.
    +
    +-->
    +
    +  <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <parent>
    +      <groupId>org.apache.phoenix</groupId>
    +      <artifactId>phoenix</artifactId>
    +      <version>4.4.1-HBase-0.98-SNAPSHOT</version>
    +    </parent>
    +
    +    <artifactId>phoenix-tracing-webapp</artifactId>
    +    <name>Phoenix - Tracing Web Application</name>
    +    <description>Tracing web application will visualize the phoenix traces</description>
    +
    +    <properties>
    +       <top.dir>${project.basedir}/..</top.dir>
    +    </properties>
    +
    +    <dependencies>
    +      <!--dependency>
    +        <groupId>org.eclipse.jetty</groupId>
    +        <artifactId>jetty-server</artifactId>
    --- End diff --
    
    just remove these dependencies from this PR as they're provided in the other.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---