You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by charsyam <gi...@git.apache.org> on 2014/12/26 13:15:10 UTC

[GitHub] tajo pull request: TAJO-1270 Fix typos

GitHub user charsyam opened a pull request:

    https://github.com/apache/tajo/pull/321

    TAJO-1270 Fix typos

    Fix typos for tajo files
    Major Change:
    in DefaultTajoCliOutputFormatter.java
    change function name:
    setScirptMode -> setScriptMode


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/charsyam/tajo feature/misspelling

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #321
    
----
commit 8824e607595bf847cdeb9f337c4304546cf81b76
Author: clark.kang <cl...@kakao.com>
Date:   2014-12-26T12:11:27Z

    fix typos

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1270 Fix typos

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/321#issuecomment-68897736
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1270 Fix typos

Posted by charsyam <gi...@git.apache.org>.
Github user charsyam commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/321#discussion_r22284663
  
    --- Diff: tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java ---
    @@ -134,7 +134,7 @@ private Path getDataFile(ExecutionBlockId ebId, int partId) throws IOException {
         }
     
         // Send Intermediate data to QueryMaster.
    -    List<HashShuffleIntermediate> intermEntries = new ArrayList<HashShuffleIntermediate>();
    +    List<HashShuffleIntermediate> interimEntries = new ArrayList<HashShuffleIntermediate>();
    --- End diff --
    
    @blrunner I add it. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1270 Fix typos

Posted by charsyam <gi...@git.apache.org>.
Github user charsyam commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/321#discussion_r22284346
  
    --- Diff: tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java ---
    @@ -134,7 +134,7 @@ private Path getDataFile(ExecutionBlockId ebId, int partId) throws IOException {
         }
     
         // Send Intermediate data to QueryMaster.
    -    List<HashShuffleIntermediate> intermEntries = new ArrayList<HashShuffleIntermediate>();
    +    List<HashShuffleIntermediate> interimEntries = new ArrayList<HashShuffleIntermediate>();
    --- End diff --
    
    @blrunner I check it from "http://en.wikipedia.org/wiki/Intermediate_state"
    it mention like this, "the intermediate state or interim state"
    so I changed it because interim is more meaningful.
    But I also think it doesn't need to change strongly 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1270 Fix typos

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/321#discussion_r22284429
  
    --- Diff: tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java ---
    @@ -134,7 +134,7 @@ private Path getDataFile(ExecutionBlockId ebId, int partId) throws IOException {
         }
     
         // Send Intermediate data to QueryMaster.
    -    List<HashShuffleIntermediate> intermEntries = new ArrayList<HashShuffleIntermediate>();
    +    List<HashShuffleIntermediate> interimEntries = new ArrayList<HashShuffleIntermediate>();
    --- End diff --
    
    It's a good opinion. I also agree with you.
    If you possible, could you update Repartitioner::scheduleSymmetricRepartitionJoin? There is a variable named "intermEntry". 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1270 Fix typos

Posted by charsyam <gi...@git.apache.org>.
Github user charsyam commented on the pull request:

    https://github.com/apache/tajo/pull/321#issuecomment-68861496
  
    @blrunner @hyunsik I changed interim to intermididate :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1270 Fix typos

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/321#discussion_r22291234
  
    --- Diff: tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java ---
    @@ -134,7 +134,7 @@ private Path getDataFile(ExecutionBlockId ebId, int partId) throws IOException {
         }
     
         // Send Intermediate data to QueryMaster.
    -    List<HashShuffleIntermediate> intermEntries = new ArrayList<HashShuffleIntermediate>();
    +    List<HashShuffleIntermediate> interimEntries = new ArrayList<HashShuffleIntermediate>();
    --- End diff --
    
    It just means that intermediate data and its related things. It is not related to the contents in the wiki page. I recommend using a full name 'intermediateEntry'.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1270 Fix typos

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/321#issuecomment-68897825
  
    Thank you @charsyam for your work :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1270 Fix typos

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/321#issuecomment-68671308
  
    Sorry for my late review.
    I also agree with @hyunsik's opinion and current words looks good compare than the full name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1270 Fix typos

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/321#discussion_r22284199
  
    --- Diff: tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java ---
    @@ -134,7 +134,7 @@ private Path getDataFile(ExecutionBlockId ebId, int partId) throws IOException {
         }
     
         // Send Intermediate data to QueryMaster.
    -    List<HashShuffleIntermediate> intermEntries = new ArrayList<HashShuffleIntermediate>();
    +    List<HashShuffleIntermediate> interimEntries = new ArrayList<HashShuffleIntermediate>();
    --- End diff --
    
    It doesn't seem to be a typo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1270 Fix typos

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/321


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---