[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1233: MINIFICPP-1684 - Provide agent logs through the c2 protocol

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #1233:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1233#discussion_r780375784



##########
File path: extensions/http-curl/client/HTTPClient.cpp
##########
@@ -62,6 +76,10 @@ HTTPClient::~HTTPClient() {
     curl_easy_cleanup(http_session_);
     http_session_ = nullptr;
   }
+  if (form_ != nullptr) {
+    curl_mime_free(form_);

Review comment:
       Could you disable the copy of HTTPClient to make this (and the rest of the class) safe?

##########
File path: extensions/http-curl/protocols/RESTSender.h
##########
@@ -52,7 +52,7 @@ class RESTSender : public RESTProtocol, public C2Protocol {
   void initialize(core::controller::ControllerServiceProvider* controller, const std::shared_ptr<Configure> &configure) override;
 
  protected:
-  virtual const C2Payload sendPayload(const std::string url, const Direction direction, const C2Payload &payload, const std::string outputConfig);
+  const C2Payload sendPayload(const std::string url, const Direction direction, const C2Payload &payload, std::optional<std::string> data);

Review comment:
       Since this is no longer virtual, could you also remove `const` from the return type? Top-level `const` is ignored in the return type.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org