You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/01 01:48:56 UTC
[GitHub] [arrow] MannySchneck opened a new pull request, #14554: cache infertype dictionary creation for consistent typeids
MannySchneck opened a new pull request, #14554:
URL: https://github.com/apache/arrow/pull/14554
resolves: https://issues.apache.org/jira/browse/ARROW-18208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #14554: ARROW-18208 [JS] Fixes crash when inferring objects with string-valued keys nested in an array
Posted by GitBox <gi...@apache.org>.
domoritz commented on PR #14554:
URL: https://github.com/apache/arrow/pull/14554#issuecomment-1383285060
Thanks for the pull request. Can you remove the comments and implement the right fix that also works in duckdb? I'm closing this pull request for now since it's incomplete but would be happy to reopen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14554: cache infertype dictionary creation for consistent typeids
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14554:
URL: https://github.com/apache/arrow/pull/14554#issuecomment-1297907922
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14554: ARROW-18208 [JS] Fixes crash when inferring objects with string-valued keys nested in an array
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14554:
URL: https://github.com/apache/arrow/pull/14554#issuecomment-1297909575
:warning: Ticket **has no components in JIRA**, make sure you assign one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14554: ARROW-18208 [JS] Fixes crash when inferring objects with string-valued keys nested in an array
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14554:
URL: https://github.com/apache/arrow/pull/14554#issuecomment-1297909535
https://issues.apache.org/jira/browse/ARROW-18208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14554: ARROW-18208 [JS] Fixes crash when inferring objects with string-valued keys nested in an array
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14554:
URL: https://github.com/apache/arrow/pull/14554#issuecomment-1297909589
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MannySchneck commented on pull request #14554: ARROW-18208 [JS] Fixes crash when inferring objects with string-valued keys nested in an array
Posted by GitBox <gi...@apache.org>.
MannySchneck commented on PR #14554:
URL: https://github.com/apache/arrow/pull/14554#issuecomment-1298946553
This "fix" breaks duckdb, which is my use case, and as such is not really a "fix".
```
Uncaught (in promise) Error: Cannot create Schema containing two different dictionaries with the same Id
at collectDictionaries (recordbatch.ts:329:23)
at get dictionaries [as dictionaries] (recordbatch.ts:99:60)
at RecordBatchStreamWriter._writeDictionaries (writer.ts:285:44)
at RecordBatchStreamWriter._writeRecordBatch (writer.ts:254:14)
at RecordBatchStreamWriter.write (writer.ts:183:22)
at writeAll (writer.ts:441:16)
at RecordBatchStreamWriter.writeAll (writer.ts:312:16)
at Module.tableToIPC (serialization.ts:63:10)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz closed pull request #14554: ARROW-18208 [JS] Fixes crash when inferring objects with string-valued keys nested in an array
Posted by GitBox <gi...@apache.org>.
domoritz closed pull request #14554: ARROW-18208 [JS] Fixes crash when inferring objects with string-valued keys nested in an array
URL: https://github.com/apache/arrow/pull/14554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] MannySchneck commented on pull request #14554: ARROW-18208 [JS] Fixes crash when inferring objects with string-valued keys nested in an array
Posted by GitBox <gi...@apache.org>.
MannySchneck commented on PR #14554:
URL: https://github.com/apache/arrow/pull/14554#issuecomment-1297910163
Reverted the code change and re-ran the test I wrote:
```
manny|arrow/js> yarn test
yarn run v1.22.19
$ cross-env NODE_NO_WARNINGS=1 gulp test
[20:50:59] Using gulpfile ~/code/arrow/js/gulpfile.js
[20:50:59] Starting 'test'...
[20:50:59] Starting 'test:ts'...
[20:50:59] Starting 'test:src'...
[20:50:59] Starting 'test:apache-arrow'...
[20:50:59] Starting 'test:es5:cjs'...
Determining test suites to run...Determining test suites to run...Determining test suites to run...Determini
ts-jest[ts-jest-transformer] (WARN) Define `ts-jest` config under `globals` is deprecated. Please do
transform: {
<transform_regex>: ['ts-jest', { /* ts-jest config goes here in Jest */ }],
},
ts-jest[ts-jest-transformer] (WARN) Define `ts-jest` config under `globals` is deprecated. Please do
transform: {
<transform_regex>: ['ts-jest', { /* ts-jest config goes here in Jest */ }],
},
ts-jest[ts-jest-transformer] (WARN) Define `ts-jest` config under `globals` is deprecated. Please do
transform: {
<transform_regex>: ['ts-jest', { /* ts-jest config goes here in Jest */ }],
},
ts-jest[ts-jest-transformer] (WARN) Define `ts-jest` config under `globals` is deprecated. Please do
transform: {
<transform_regex>: ['ts-jest', { /* ts-jest config goes here in Jest */ }],
},
● tableFromJSON() › creates table from objects with string values nested in an array
TypeError: Unable to infer Vector type from input values, explicit type declaration expected
166 | }
167 |
> 168 | throw new TypeError('Unable to infer Vector type from input values, explicit type declaration expected');
| ^
169 | }
170 |
171 | /**
at inferType (targets/ts/factories.ts:168:11)
at inferType (targets/ts/factories.ts:161:52)
at vectorFromArray (targets/ts/factories.ts:86:61)
at tableFromJSON (targets/ts/factories.ts:101:20)
at Object.<anonymous> (test/unit/table/table-test.ts:83:16)
● tableFromJSON() › creates table from objects with string values nested in an array
TypeError: Unable to infer Vector type from input values, explicit type declaration expected
166 | }
167 |
> 168 | throw new TypeError('Unable to infer Vector type from input values, explicit type declaration expected');
| ^
169 | }
170 |
171 | /**
at inferType (targets/apache-arrow/src/factories.ts:168:11)
at inferType (targets/apache-arrow/src/factories.ts:161:52)
at vectorFromArray (targets/apache-arrow/src/factories.ts:86:61)
at tableFromJSON (targets/apache-arrow/src/factories.ts:101:20)
at Object.<anonymous> (test/unit/table/table-test.ts:83:29)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org