[GitHub] viirya commented on a change in pull request #23759: [SPARK-26840][SQL] Avoid cost-based join reorder in presence of join hints

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #23759: [SPARK-26840][SQL] Avoid cost-based join reorder in presence of join hints
URL: https://github.com/apache/spark/pull/23759#discussion_r255364163
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
 ##########
 @@ -77,24 +77,24 @@ object CostBasedJoinReorder extends Rule[LogicalPlan] with PredicateHelper {
    */
   private def extractInnerJoins(plan: LogicalPlan): (Seq[LogicalPlan], Set[Expression]) = {
     plan match {
-      case Join(left, right, _: InnerLike, Some(cond), _) =>
+      case Join(left, right, _: InnerLike, Some(cond), hint) if hint == JoinHint.NONE =>
 
 Review comment:
   I think we can use pattern match as @dongjoon-hyun's PR, it will be simpler.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org