You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/01 07:05:37 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #651: [WIP] Prevent form from closing if validation fails
davidjumani opened a new pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-689511617
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#discussion_r485493632
##########
File path: src/views/AutogenView.vue
##########
@@ -831,6 +831,11 @@ export default {
this.actionLoading = true
for (const params of paramsList) {
api(this.currentAction.api, params).then(json => {
+ setTimeout(() => {
Review comment:
Would this cause an issue if the form is closed for group actions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-689500793
@rhtyd Yes, in case there was a network or validation error. That way the user won't have to enter all the details all over again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-687004657
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-686272652
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-693287045
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-687004305
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-692662289
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/651 (JID-3474)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-693286466
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-692658482
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-687010564
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/651 (JID-3427)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-693291581
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/651 (JID-3480)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-689521862
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/651 (JID-3449)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-686907318
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-689462802
@davidjumani general question - if we're not handling in `finally` Do we want the form to stay open in case of error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-689512238
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-692618448
@davidjumani can you address merge conflict?
@utchoang can you help review/test this? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #651: Prevent form from closing if validation fails
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #651:
URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-692657816
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org