You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/29 19:12:01 UTC

[GitHub] [incubator-nuttx-apps] acassis commented on a change in pull request #867: industry/foc: add support for Hall sensor and Qencoder feedback

acassis commented on a change in pull request #867:
URL: https://github.com/apache/incubator-nuttx-apps/pull/867#discussion_r739475513



##########
File path: include/industry/foc/foc_common.h
##########
@@ -71,6 +71,15 @@ enum foc_ramp_mode_e
   RAMP_MODE_NORMAL    = 3,      /* Normal operation */
 };
 
+/* Angle handler type */
+
+enum foc_angle_type_e
+{
+  FOC_ANGLE_TYPE_INVALID = 0,  /* Reserved */
+  FOC_ANGLE_TYPE_ELE     = 1,  /* Electrical angle */
+  FOC_ANGLE_TYPE_MECH    = 2,  /* Mechanical angle */

Review comment:
       @raiden00pl why do we need to have two separated types of FOC Angles ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org