You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2025/09/28 18:06:59 UTC
[PR] Improve EC2 benchmarking guide [datafusion-comet]
andygrove opened a new pull request, #2474:
URL: https://github.com/apache/datafusion-comet/pull/2474
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: Improve EC2 benchmarking guide [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #2474:
URL: https://github.com/apache/datafusion-comet/pull/2474#discussion_r2388478559
##########
docs/source/contributor-guide/benchmarking_aws_ec2.md:
##########
@@ -148,76 +157,11 @@ aws_access_key_id=your-access-key
aws_secret_access_key=your-secret-key
```
-## Run Spark Benchmarks
-
-Run the following command (the `--data` parameter will need to be updated to point to your S3 bucket):
-
-```shell
-$SPARK_HOME/bin/spark-submit \
- --master $SPARK_MASTER \
- --conf spark.driver.memory=4G \
- --conf spark.executor.instances=1 \
- --conf spark.executor.cores=8 \
- --conf spark.cores.max=8 \
- --conf spark.executor.memory=16g \
- --conf spark.eventLog.enabled=false \
- --conf spark.local.dir=/mnt/tmp \
- --conf spark.driver.extraJavaOptions="-Djava.io.tmpdir=/mnt/tmp" \
- --conf spark.executor.extraJavaOptions="-Djava.io.tmpdir=/mnt/tmp" \
- --conf spark.hadoop.fs.s3a.impl=org.apache.hadoop.fs.s3a.S3AFileSystem \
- --conf spark.hadoop.fs.s3a.aws.credentials.provider=com.amazonaws.auth.DefaultAWSCredentialsProviderChain \
- tpcbench.py \
- --benchmark tpch \
- --data s3a://your-bucket-name/top-level-folder \
- --queries /home/ec2-user/datafusion-benchmarks/tpch/queries \
- --output . \
- --iterations 1
-```
-
-## Run Comet Benchmarks
-
-Install Comet JAR from Maven:
-
-```shell
-wget https://repo1.maven.org/maven2/org/apache/datafusion/comet-spark-spark3.5_2.12/0.9.0/comet-spark-spark3.5_2.12-0.9.0.jar -P $SPARK_HOME/jars
-export COMET_JAR=$SPARK_HOME/jars/comet-spark-spark3.5_2.12-0.9.0.jar
-```
-
-Run the following command (the `--data` parameter will need to be updated to point to your S3 bucket):
-
-```shell
-$SPARK_HOME/bin/spark-submit \
- --master $SPARK_MASTER \
- --conf spark.driver.memory=4G \
- --conf spark.executor.instances=1 \
- --conf spark.executor.cores=8 \
- --conf spark.cores.max=8 \
- --conf spark.executor.memory=16g \
- --conf spark.memory.offHeap.enabled=true \
- --conf spark.memory.offHeap.size=16g \
- --conf spark.eventLog.enabled=false \
- --conf spark.local.dir=/mnt/tmp \
- --conf spark.driver.extraJavaOptions="-Djava.io.tmpdir=/mnt/tmp" \
- --conf spark.executor.extraJavaOptions="-Djava.io.tmpdir=/mnt/tmp" \
- --conf spark.hadoop.fs.s3a.impl=org.apache.hadoop.fs.s3a.S3AFileSystem \
- --conf spark.hadoop.fs.s3a.aws.credentials.provider=com.amazonaws.auth.DefaultAWSCredentialsProviderChain \
- --jars $COMET_JAR \
- --driver-class-path $COMET_JAR \
- --conf spark.driver.extraClassPath=$COMET_JAR \
- --conf spark.executor.extraClassPath=$COMET_JAR \
- --conf spark.plugins=org.apache.spark.CometPlugin \
- --conf spark.shuffle.manager=org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager \
- --conf spark.comet.enabled=true \
- --conf spark.comet.expression.allowIncompatible=true \
- --conf spark.comet.exec.replaceSortMergeJoin=true \
- --conf spark.comet.exec.shuffle.enabled=true \
- --conf spark.comet.exec.shuffle.fallbackToColumnar=true \
- --conf spark.comet.exec.shuffle.compression.codec=lz4 \
- --conf spark.comet.exec.shuffle.compression.level=1 \
- tpcbench.py \
- --benchmark tpch \
- --data s3a://your-bucket-name/top-level-folder \
- --queries /home/ec2-user/datafusion-benchmarks/tpch/queries \
- --output . \
- --iterations 1
+Modify the scripts to add the following configurations.
+
+```shell
+--conf spark.hadoop.fs.s3a.impl=org.apache.hadoop.fs.s3a.S3AFileSystem \
+--conf spark.hadoop.fs.s3a.aws.credentials.provider=com.amazonaws.auth.DefaultAWSCredentialsProviderChain \
```
+
+Now run the `spark-tpch.sh` and `comet-tpch.sh` scripts.
Review Comment:
Probably we need to highlight where to find benchmark results?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: Improve EC2 benchmarking guide [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #2474:
URL: https://github.com/apache/datafusion-comet/pull/2474#discussion_r2389372975
##########
docs/source/contributor-guide/benchmarking_aws_ec2.md:
##########
@@ -148,76 +157,11 @@ aws_access_key_id=your-access-key
aws_secret_access_key=your-secret-key
```
-## Run Spark Benchmarks
-
-Run the following command (the `--data` parameter will need to be updated to point to your S3 bucket):
-
-```shell
-$SPARK_HOME/bin/spark-submit \
- --master $SPARK_MASTER \
- --conf spark.driver.memory=4G \
- --conf spark.executor.instances=1 \
- --conf spark.executor.cores=8 \
- --conf spark.cores.max=8 \
- --conf spark.executor.memory=16g \
- --conf spark.eventLog.enabled=false \
- --conf spark.local.dir=/mnt/tmp \
- --conf spark.driver.extraJavaOptions="-Djava.io.tmpdir=/mnt/tmp" \
- --conf spark.executor.extraJavaOptions="-Djava.io.tmpdir=/mnt/tmp" \
- --conf spark.hadoop.fs.s3a.impl=org.apache.hadoop.fs.s3a.S3AFileSystem \
- --conf spark.hadoop.fs.s3a.aws.credentials.provider=com.amazonaws.auth.DefaultAWSCredentialsProviderChain \
- tpcbench.py \
- --benchmark tpch \
- --data s3a://your-bucket-name/top-level-folder \
- --queries /home/ec2-user/datafusion-benchmarks/tpch/queries \
- --output . \
- --iterations 1
-```
-
-## Run Comet Benchmarks
-
-Install Comet JAR from Maven:
-
-```shell
-wget https://repo1.maven.org/maven2/org/apache/datafusion/comet-spark-spark3.5_2.12/0.9.0/comet-spark-spark3.5_2.12-0.9.0.jar -P $SPARK_HOME/jars
-export COMET_JAR=$SPARK_HOME/jars/comet-spark-spark3.5_2.12-0.9.0.jar
-```
-
-Run the following command (the `--data` parameter will need to be updated to point to your S3 bucket):
-
-```shell
-$SPARK_HOME/bin/spark-submit \
- --master $SPARK_MASTER \
- --conf spark.driver.memory=4G \
- --conf spark.executor.instances=1 \
- --conf spark.executor.cores=8 \
- --conf spark.cores.max=8 \
- --conf spark.executor.memory=16g \
- --conf spark.memory.offHeap.enabled=true \
- --conf spark.memory.offHeap.size=16g \
- --conf spark.eventLog.enabled=false \
- --conf spark.local.dir=/mnt/tmp \
- --conf spark.driver.extraJavaOptions="-Djava.io.tmpdir=/mnt/tmp" \
- --conf spark.executor.extraJavaOptions="-Djava.io.tmpdir=/mnt/tmp" \
- --conf spark.hadoop.fs.s3a.impl=org.apache.hadoop.fs.s3a.S3AFileSystem \
- --conf spark.hadoop.fs.s3a.aws.credentials.provider=com.amazonaws.auth.DefaultAWSCredentialsProviderChain \
- --jars $COMET_JAR \
- --driver-class-path $COMET_JAR \
- --conf spark.driver.extraClassPath=$COMET_JAR \
- --conf spark.executor.extraClassPath=$COMET_JAR \
- --conf spark.plugins=org.apache.spark.CometPlugin \
- --conf spark.shuffle.manager=org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager \
- --conf spark.comet.enabled=true \
- --conf spark.comet.expression.allowIncompatible=true \
- --conf spark.comet.exec.replaceSortMergeJoin=true \
- --conf spark.comet.exec.shuffle.enabled=true \
- --conf spark.comet.exec.shuffle.fallbackToColumnar=true \
- --conf spark.comet.exec.shuffle.compression.codec=lz4 \
- --conf spark.comet.exec.shuffle.compression.level=1 \
- tpcbench.py \
- --benchmark tpch \
- --data s3a://your-bucket-name/top-level-folder \
- --queries /home/ec2-user/datafusion-benchmarks/tpch/queries \
- --output . \
- --iterations 1
+Modify the scripts to add the following configurations.
+
+```shell
+--conf spark.hadoop.fs.s3a.impl=org.apache.hadoop.fs.s3a.S3AFileSystem \
+--conf spark.hadoop.fs.s3a.aws.credentials.provider=com.amazonaws.auth.DefaultAWSCredentialsProviderChain \
```
+
+Now run the `spark-tpch.sh` and `comet-tpch.sh` scripts.
Review Comment:
Thanks, I'll go ahead and merge this one but will follow up in a separate PR when I update the official benchmark results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: Improve EC2 benchmarking guide [datafusion-comet]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2474:
URL: https://github.com/apache/datafusion-comet/pull/2474#issuecomment-3347627370
## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2474?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 22.22%. Comparing base ([`f09f8af`](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0ad1858`](https://app.codecov.io/gh/apache/datafusion-comet/commit/0ad18582165edcca3139932043ca5bfda0402dbc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 550 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2474 +/- ##
=============================================
- Coverage 56.12% 22.22% -33.90%
+ Complexity 976 443 -533
=============================================
Files 119 146 +27
Lines 11743 13510 +1767
Branches 2251 2350 +99
=============================================
- Hits 6591 3003 -3588
- Misses 4012 9954 +5942
+ Partials 1140 553 -587
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/2474?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: Improve EC2 benchmarking guide [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #2474:
URL: https://github.com/apache/datafusion-comet/pull/2474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org