You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/06/21 11:11:47 UTC
[GitHub] codecov-io commented on issue #376: SCB-680 Optimize find instance
api
codecov-io commented on issue #376: SCB-680 Optimize find instance api
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/376#issuecomment-399066271
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/376?src=pr&el=h1) Report
> Merging [#376](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/376?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/75c5ba2e034ae553ce94319b5633805cb1ea5cce?src=pr&el=desc) will **increase** coverage by `0.3%`.
> The diff coverage is `95.74%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/376?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #376 +/- ##
=========================================
+ Coverage 69.94% 70.24% +0.3%
=========================================
Files 25 26 +1
Lines 3746 3784 +38
=========================================
+ Hits 2620 2658 +38
Misses 938 938
Partials 188 188
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/376?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/service/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/376/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZGVwZW5kZW5jeS5nbw==) | `73.17% <ø> (-0.43%)` | :arrow_down: |
| [server/service/watch.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/376/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvd2F0Y2guZ28=) | `70.96% <0%> (ø)` | :arrow_up: |
| [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/376/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.55% <100%> (+1.14%)` | :arrow_up: |
| [server/service/util/find\_cache.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/376/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9maW5kX2NhY2hlLmdv) | `100% <100%> (ø)` | |
| [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/376/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `50.45% <80%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/376?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/376?src=pr&el=footer). Last update [75c5ba2...e6ed348](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/376?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services