[GitHub] [bookkeeper] rdhabalia opened a new pull request #2156: [bookie-mTLS] add support of hostname verification

[GitBox <gi...@apache.org>]

rdhabalia opened a new pull request #2156: [bookie-mTLS] add support of hostname verification
URL: https://github.com/apache/bookkeeper/pull/2156
 
 
   ### Motivation
   
   Right now, bookkeeper-client is not able to perform [hostname-verification](https://tersesystems.com/blog/2014/03/23/fixing-hostname-verification/) when it connects to broker over tls. Hostname-verification feature is already implemented in almost all [http-client](https://github.com/apache/httpcomponents-client/blob/master/httpclient5/src/main/java/org/apache/hc/client5/http/ssl/DefaultHostnameVerifier.java) but it's not supported by [netty](https://stackoverflow.com/questions/13315623/netty-ssl-hostname-verification-support) yet. therefore, client should be able to perform hostname-verification as per [RFC-2181](https://tools.ietf.org/html/rfc2818#section-3.1)
   
   ### Modifications
   
   - added client configuration to enable hostname-verification (default disable)
   - use [http-client](https://github.com/apache/httpcomponents-client/blob/master/httpclient5/src/main/java/org/apache/hc/client5/http/ssl/DefaultHostnameVerifier.java) but it's not supported by [netty](https://stackoverflow.com/questions/13315623/netty-ssl-hostname-verification-support) to perform hostname-validation rather adding custom logic.
   - add httpclient-apache dependency into LICENSE and NOTICE files.
   
   ### Result
   
   Bookkeeper client will be able to perform hostname verification while creating ssl session with bookie.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services