[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #1426: feat: support redirect and requestHeaderModifier in HTTPRoute filter

[GitBox <gi...@apache.org>]

AlinsRan commented on code in PR #1426:
URL: https://github.com/apache/apisix-ingress-controller/pull/1426#discussion_r1012524418


##########
pkg/providers/gateway/translation/gateway_httproute.go:
##########
@@ -32,6 +32,77 @@ import (
 	apisixv1 "github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
 )
 
+func (t *translator) generatePluginsFromHTTPRouteFilter(filters []gatewayv1alpha2.HTTPRouteFilter) apisixv1.Plugins {
+	plugins := apisixv1.Plugins{}
+	for _, filter := range filters {
+		switch filter.Type {
+		case gatewayv1alpha2.HTTPRouteFilterRequestHeaderModifier:
+			t.fillPluginsFromHTTPRequestHeaderFilter(plugins, filter.RequestHeaderModifier)
+		case gatewayv1alpha2.HTTPRouteFilterRequestRedirect:
+			t.fillPluginsFromHTTPRequestRedirectFilter(plugins, filter.RequestRedirect)
+		case gatewayv1alpha2.HTTPRouteFilterRequestMirror:
+			// to do
+		}
+	}
+	return plugins
+}
+
+func (t *translator) fillPluginsFromHTTPRequestHeaderFilter(plugins apisixv1.Plugins, reqHeaderModifier *gatewayv1alpha2.HTTPRequestHeaderFilter) {
+	if reqHeaderModifier == nil {
+		return
+	}
+	headers := map[string]any{}
+	for _, header := range reqHeaderModifier.Add {
+		headers[string(header.Name)] = header.Value

Review Comment:
   I know, but I can't achieve it. What do you think should I do?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org