You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/24 23:47:05 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #9019: [SQL
Lab] Cache function names query
etr2460 opened a new pull request #9019: [SQL Lab] Cache function names query
URL: https://github.com/apache/incubator-superset/pull/9019
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
As I tested this further, I realized that this was making a query to every presto and hive db whenever you open SQL Lab or open a new SQL Lab tab. This PR caches the result of the `show function` query as we don't expect it to change often.
### TEST PLAN
Add a print statement to the function, see it the first time I open SQL Lab, but then when opening subsequent SQL Lab tabs, don't see the print statement again
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @john-bodley @villebro @betodealmeida
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #9019: [SQL Lab]
Cache function names query
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #9019: [SQL Lab] Cache function names query
URL: https://github.com/apache/incubator-superset/pull/9019
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org