You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/17 15:59:41 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #8982:
[dashboards] Set default get columns to just id when not defined
dpgaspar opened a new pull request #8982: [dashboards] Set default get columns to just id when not defined
URL: https://github.com/apache/incubator-superset/pull/8982
### CATEGORY
Choose one
- [ ] Bug Fix
- [X] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Limit get default columns from all ModelRestApi when nothing is defined
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8982: [api] Set
default get columns to just id when not defined
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8982: [api] Set default get columns to just id when not defined
URL: https://github.com/apache/incubator-superset/pull/8982#issuecomment-575689063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=h1) Report
> Merging [#8982](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c087a48d5289767e0ae29205318c11a27963d496?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8982 +/- ##
=======================================
Coverage 59.15% 59.15%
=======================================
Files 367 367
Lines 11681 11681
Branches 2863 2863
=======================================
Hits 6910 6910
Misses 4592 4592
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=footer). Last update [c087a48...1df6593](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #8982: [api] fix,
set default columns to just id when not defined
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #8982: [api] fix, set default columns to just id when not defined
URL: https://github.com/apache/incubator-superset/pull/8982#issuecomment-577257782
Added tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull
request #8982: [api] fix, set default columns to just id when not defined
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #8982: [api] fix, set default columns to just id when not defined
URL: https://github.com/apache/incubator-superset/pull/8982#discussion_r369844729
##########
File path: superset/views/base_api.py
##########
@@ -82,6 +82,18 @@ class BaseSupersetModelRestApi(ModelRestApi):
}
""" # pylint: disable=pointless-string-statement
+ def _init_properties(self):
Review comment:
Would it be possible to set the default column list to `[]` (empty array) to have nothing returned by default? Database primary keys can be sensitive under certain circumstances.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #8982: [api] fix,
set default columns to just id when not defined
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #8982: [api] fix, set default columns to just id when not defined
URL: https://github.com/apache/incubator-superset/pull/8982
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull
request #8982: [api] fix, set default columns to just id when not defined
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #8982: [api] fix, set default columns to just id when not defined
URL: https://github.com/apache/incubator-superset/pull/8982#discussion_r371982094
##########
File path: superset/views/base_api.py
##########
@@ -82,6 +82,18 @@ class BaseSupersetModelRestApi(ModelRestApi):
}
""" # pylint: disable=pointless-string-statement
+ def _init_properties(self):
Review comment:
I think being able to default to fully-closed is important. This isn't a blocker for this PR, but it's a change I would really like to see on FAB.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8982:
[api] fix, set default columns to just id when not defined
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8982: [api] fix, set default columns to just id when not defined
URL: https://github.com/apache/incubator-superset/pull/8982#issuecomment-575689063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=h1) Report
> Merging [#8982](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d851a60acfd081a5941bf277c7d2a14fa1a30e79?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8982 +/- ##
==========================================
+ Coverage 59.15% 59.16% +0.01%
==========================================
Files 367 367
Lines 11681 11679 -2
Branches 2863 2862 -1
==========================================
Hits 6910 6910
+ Misses 4592 4590 -2
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvRGF0ZUZpbHRlckNvbnRyb2wuanN4) | `38.78% <100%> (+0.46%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=footer). Last update [d851a60...c233e57](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8982:
[api] Set default columns to just id when not defined
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8982: [api] Set default columns to just id when not defined
URL: https://github.com/apache/incubator-superset/pull/8982#issuecomment-575689063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=h1) Report
> Merging [#8982](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d851a60acfd081a5941bf277c7d2a14fa1a30e79?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8982 +/- ##
==========================================
+ Coverage 59.15% 59.16% +0.01%
==========================================
Files 367 367
Lines 11681 11679 -2
Branches 2863 2862 -1
==========================================
Hits 6910 6910
+ Misses 4592 4590 -2
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvRGF0ZUZpbHRlckNvbnRyb2wuanN4) | `38.78% <100%> (+0.46%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=footer). Last update [d851a60...c97eb7c](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8982:
[api] Set default columns to just id when not defined
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8982: [api] Set default columns to just id when not defined
URL: https://github.com/apache/incubator-superset/pull/8982#issuecomment-575689063
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=h1) Report
> Merging [#8982](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c087a48d5289767e0ae29205318c11a27963d496?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8982 +/- ##
=======================================
Coverage 59.15% 59.15%
=======================================
Files 367 367
Lines 11681 11681
Branches 2863 2863
=======================================
Hits 6910 6910
Misses 4592 4592
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=footer). Last update [c087a48...d851a60](https://codecov.io/gh/apache/incubator-superset/pull/8982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request
#8982: [api] fix, set default columns to just id when not defined
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #8982: [api] fix, set default columns to just id when not defined
URL: https://github.com/apache/incubator-superset/pull/8982#discussion_r370646758
##########
File path: superset/views/base_api.py
##########
@@ -82,6 +82,18 @@ class BaseSupersetModelRestApi(ModelRestApi):
}
""" # pylint: disable=pointless-string-statement
+ def _init_properties(self):
Review comment:
Everything is possible, on this case would probably involve a somewhat delicate change on FAB. My take is that, this is just a fallback, enough to force everyone to always declare CRUD fields explicitly or else the API will return nothing of value (like just the id's)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org