You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@karaf.apache.org by Steinar Bang <sb...@dod.no> on 2019/10/05 08:00:08 UTC
Re: Review of jackson features
>>>>> Steinar Bang <sb...@dod.no>:
>>>>> Jean-Baptiste Onofré <jb...@nanthrax.net>:
>> Hi Steinar,
>> Not yet, I was busy with 4.2.7 preparation, I will take a look tomorrow.
> Ok. Thanks! :-)
@JB have you had time to look at the changes? (summary repeated below)
(Note: if you don't have time that's OK. I can just submit the PRs as
they are. I think they work (sort of, I'm unsure of the
jackson-datatype-hibernate for hibernate versions other than 5). At
least all features have successfully loaded in karaf 4.2.6)
Here's a summary of the changes:
1. jackson-parent:
Issue: https://github.com/FasterXML/jackson-parent/issues/11
git branch: https://github.com/steinarb/jackson-parent/tree/add-apache-karaf-features-to-jackson
Contains karaf-maven-plugin configuration in pluginManagement:
- Uses karaf 4.2.6
- Binds feature-generate-descriptor to the package phase
- includeTransitiveDependency: false
- aggregateFeatures: false
- includeProjectArtifact: true
2. jackson-bom:
Issue: https://github.com/FasterXML/jackson-bom/issues/27
git branch: https://github.com/steinarb/jackson-bom/tree/add-apache-karaf-features-to-jackson
Changes:
- Use snapshot versions for everything (without this the branch
won't build)
- Add a module that attaches a hand-written master feature
repository that will load all jersey feature repositories
3. jackson-annotations
Issue: https://github.com/FasterXML/jackson-annotations/issues/160
git branch: https://github.com/steinarb/jackson-annotations/tree/add-apache-karaf-features-to-jackson
Changes:
- Use snapshot for the parent version
- Reference the karaf-maven-plugin in the plugins section
4. jackson-core
Issue: https://github.com/FasterXML/jackson-core/issues/560
git branch: https://github.com/steinarb/jackson-core/tree/add-apache-karaf-features-to-jackson
Changes:
- Reference the karaf-maven-plugin in the plugins section
5. jackson-databind
Issue: https://github.com/FasterXML/jackson-databind/issues/2434 (this is also the initial issue I created)
git branch: https://github.com/steinarb/jackson-databind/tree/add-apache-karaf-features-to-jackson
Changes:
- Reference the karaf-maven-plugin in the plugins section
- Make the jackson-annotation and jackson-core maven dependencies provided
- Add a template feature.xml depending on the jackson-annotation and jackson-core features
6. jackson-modules-base
Issue: https://github.com/FasterXML/jackson-modules-base/issues/86
git branch: https://github.com/steinarb/jackson-modules-base/tree/add-apache-karaf-features-to-jackson
Changes in each of the modules:
- Reference the karaf-maven-plugin in the plugins section
- Make the jackson-annotation and/or jackson-core and/or jackson-databind
maven dependencies provided
- Add a template feature.xml depending on the jackson-databind
feature (or just jackson-core and jackson-annotations for the
mrbean module)
- In guice:
- change config includeTransitiveDependency to true
- exclude javax.inject to avoid wrapping javax.inject in the
jackson-module-guice feature (a wrapped javax.inject will break
jersey)
- add javax.inject as a provided dependency (so that things will
compile)
- depend on the built-in feature transaction-api, to get
javax.inject from a properly versioned OSGi bundle
7. jackson-datatypes-collections
Issue: https://github.com/FasterXML/jackson-datatypes-collections/issues/59
git branch: https://github.com/steinarb/jackson-datatypes-collections/tree/add-apache-karaf-features-to-jackson
Changes:
- In the parent pom, make jackson-annotations, jackson-core and
jackson-databind be provided dependencies
- In all modules
- Reference the karaf-maven-plugin in the plugins section
- Add a template feature.xml depending on the jackson-databind feature
- In the pcollections module change packaging from jar to bundle
- In the eclipse-collections module include eclipse-collections as
a wrapped module in the template feature.xml (strange that wrap
was needed for an eclipse file...? The manifest of the
eclipse-collections jar was weird... possible duplicated line
breaks)
8. jackson-dataformats-binary
Issue: https://github.com/FasterXML/jackson-dataformats-binary/issues/181
git branch: https://github.com/steinarb/jackson-dataformats-binary/tree/add-apache-karaf-features-to-jackson
Changes:
- Make jackson-core provided in the top pom
- In the submodules:
- Reference the karaf-maven-plugin in the plugins section
- Add a template feature.xml pulling in jackson-databind
- In the avro module
- set includeTransitiveDependency to true
- make jackson-databind and jackson-annotations provided
- exclude guava and slf4j-api transitive dependencies
- Note: avro has dependecies to jars in an old version of jackson
See issue: https://github.com/FasterXML/jackson-dataformats-binary/issues/167
9. jackson-dataformat-xml
Issue: https://github.com/FasterXML/jackson-dataformat-xml/issues/361
git branch: https://github.com/steinarb/jackson-dataformat-xml/tree/add-apache-karaf-features-to-jackson
Changes:
- Reference the karaf-maven-plugin in the plugins section
- Make jackson-annotation, jackson-core and jackson-databind provided
- In the template feature.xml:
- Depend on the jackson-module-jaxb-annotations feature
- wrap the relaxngDatatype jar and load it as a bundle
10. jackson-datatype-hibernate
Issue: https://github.com/FasterXML/jackson-datatype-hibernate/issues/132
git branch: https://github.com/steinarb/jackson-datatype-hibernate/tree/add-apache-karaf-features-to-jackson
Changes:
- Fix some openjdk-11 test startup issues
- In the parent pom, make jackson-annotations, jackson-core and
jackson-databind be provided dependencies
- In the sub-modules:
- Reference the karaf-maven-plugin in the plugins section
- Add a template karaf.xml that
- Reference the jackson-databind feature
- Reference the built-in hibernate feature
- (The features all load, but I'm guessing the hibernate5 feature
will be the only one actually working)
11. jackson-dataformats-text
Issue: https://github.com/FasterXML/jackson-dataformats-text/issues/144
git branch: https://github.com/steinarb/jackson-dataformats-text/tree/add-apache-karaf-features-to-jackson
Changes:
- Make jackson-core provided in the parent pom
- In the modules:
- Reference the karaf-maven-plugin in the plugins section
- Add a template feature.xml referencing jackson-databind
12. jackson-datatype-joda
Issue: https://github.com/FasterXML/jackson-datatype-joda/issues/107
git branch: https://github.com/steinarb/jackson-datatype-joda/tree/add-apache-karaf-features-to-jackson
Changes:
- Reference the karaf-maven-plugin in the plugins section
- Make jackson-annotations, jackson-core and jackson-databind provided
- Add a template feature.xml referencing jackson-databind
13. jackson-datatype-json-org
Issue: https://github.com/FasterXML/jackson-datatype-json-org/issues/16
git branch: https://github.com/steinarb/jackson-datatype-json-org/tree/add-apache-karaf-features-to-jackson
Changes:
- Reference the karaf-maven-plugin in the plugins section
- Make jackson-core and jackson-databind provided
- Add a template feature.xml referencing jackson-databind
14. jackson-datatype-jsr353
Issue: https://github.com/FasterXML/jackson-datatype-jsr353/issues/12
git branch: https://github.com/steinarb/jackson-datatype-jsr353/tree/add-apache-karaf-features-to-jackson
Changes:
- Reference the karaf-maven-plugin in the plugins section
- Make jackson-core and jackson-databind provided
- Add a template feature.xml referencing jackson-databind
15. jackson-jaxrs-providers
Issue: https://github.com/FasterXML/jackson-jaxrs-providers/issues/115
git branch: https://github.com/steinarb/jackson-jaxrs-providers/tree/add-apache-karaf-features-to-jackson
Changes
- Too many to list (at this time of night), but basically
- Reference the karaf-maven-plugin in the plugins section
- Make jackson-* maven dependencies provided
- Add a template feature.xml referencing the jackson-* features
matching the maven dependencies made provided
16. jackson-jr
Issue: https://github.com/FasterXML/jackson-jr/issues/67
git branch: https://github.com/steinarb/jackson-jr/tree/add-apache-karaf-features-to-jackson
Changes
- Reference the karaf-maven-plugin in the plugins section
- Make the jackson-* dependencies provided
- Reference the features matching the dependencies made provided in
the template feature.xml
17. jackson-module-jsonSchema
Issue: https://github.com/FasterXML/jackson-module-jsonSchema/issues/138
git branch: https://github.com/steinarb/jackson-module-jsonSchema/tree/add-apache-karaf-features-to-jackson
Changes
- Reference the karaf-maven-plugin in the plugins section
- Make the jackson-* dependencies provided
- Reference the features matching the dependencies made provided in
the template feature.xml
18. jackson-modules-java8
Issue: https://github.com/FasterXML/jackson-modules-java8/issues/137
git branch: https://github.com/steinarb/jackson-modules-java8/tree/add-apache-karaf-features-to-jackson
Changes
- Remove the -Werror flag on two projects, because compiling with
openjdk-11 gave a warning that broke the build
- Reference the karaf-maven-plugin in the plugins section
- Make the jackson-* dependencies provided
- Reference the features matching the dependencies made provided in
the template feature.xml
19. jacskon-module-kotlin
Issue: https://github.com/FasterXML/jackson-module-kotlin/issues/248
git branch: https://github.com/steinarb/jackson-module-kotlin/tree/add-apache-karaf-features-to-jackson
Changes
- Reference the karaf-maven-plugin in the plugins section
- Make the jackson-* dependencies provided
- Reference the features matching the dependencies made provided in
the template feature.xml
20. jackson-module-scala
Issue: https://github.com/FasterXML/jackson-module-scala/issues/427
(no idea how to do this one, it's not using maven)
(still no idea how to do this one)
Re: Review of jackson features
Posted by Jean-Baptiste Onofre <jb...@nanthrax.net>.
Hi Steinar,
My apologizes, I forgot again :/
Can you ping me using direct email or Slack, it’s probably faster.
I will take a look tomorrow anyway.
Sorry again,
Regards
JB
> Le 11 mars 2020 à 17:57, Steinar Bang <sb...@dod.no> a écrit :
>
> Another ping on this.
>
> Possible sources for feedback to me: direct email, email to this mailing
> list (or the karaf development list if that's more appropriate), PR with
> comments, comments on the github issues related to the branches.
>
> Major issue that I know about: I've changed the dependency scope of
> dependencies to make maven-bundle-plugin and karaf-maven-plugin do the
> right thing.
>
> This may have unforseen side effects for non-OSGi maven builds that rely
> on transitive dependencies. Any such build breaks are simple to fix:
> just add the missing dependencies.
>
> But people may be annoyed when automated builds break and they have to
> investigate.
>
> (but if the changes are acceptable to the jackson maintainer, I don't
> think we have to worry. Also the changed dependencies are more
> systematic in scope usage across the various jackson projects than
> before the change)
>
> (and if the scope changes aren't acceptable to the jackson maintainer,
> there probably won't be a jackson karaf feature... at least not from
> me...:-) I don't see any other practical way of doing this)
>
Re: Review of jackson features
Posted by Steinar Bang <sb...@dod.no>.
Another ping on this.
Possible sources for feedback to me: direct email, email to this mailing
list (or the karaf development list if that's more appropriate), PR with
comments, comments on the github issues related to the branches.
Major issue that I know about: I've changed the dependency scope of
dependencies to make maven-bundle-plugin and karaf-maven-plugin do the
right thing.
This may have unforseen side effects for non-OSGi maven builds that rely
on transitive dependencies. Any such build breaks are simple to fix:
just add the missing dependencies.
But people may be annoyed when automated builds break and they have to
investigate.
(but if the changes are acceptable to the jackson maintainer, I don't
think we have to worry. Also the changed dependencies are more
systematic in scope usage across the various jackson projects than
before the change)
(and if the scope changes aren't acceptable to the jackson maintainer,
there probably won't be a jackson karaf feature... at least not from
me...:-) I don't see any other practical way of doing this)
Re: Review of jackson features
Posted by Steinar Bang <sb...@dod.no>.
>>>>> Steinar Bang <sb...@dod.no>:
>> I'm about to review. Are you on Slack as I will probably have some
>> questions ?
> Hm... I didn't know that I was, but when I tried registering I already
> was there. So appearently I am on slack, but I have absolutely no idea
> how to navigate in it. I'm logged in as sb@dod.no now.
I couldn't figure out the slack stuff, but anyway: I will respond to
comments and questions on this mailing list, on direct email and
comments on the github issues of the branches.
Re: Review of jackson features
Posted by Steinar Bang <sb...@dod.no>.
>>>>> Jean-Baptiste Onofré <jb...@nanthrax.net>:
> I'm about to review. Are you on Slack as I will probably have some
> questions ?
Hm... I didn't know that I was, but when I tried registering I already
was there. So appearently I am on slack, but I have absolutely no idea
how to navigate in it. I'm logged in as sb@dod.no now.
Re: Review of jackson features
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Steinar,
I'm about to review. Are you on Slack as I will probably have some
questions ?
Thanks,
Regards
JB
On 27/01/2020 17:16, Steinar Bang wrote:
>>>>>> Łukasz Dywicki <lu...@code-house.org>:
>
>> Hey, as changes were made last year I would not hold it too long. As
>> long as integration doesn't break Jackson build we should be fine. In
>> worst case we will have to raise an issue in jackson issue
>> tracker. ;-)
>
> The changes that I'm most unsure about, are the dependency scope changes
> (I've changed all of the dependencies that are pulled in by features to
> have <scope>provided</scope> and that in turn meant that I've had to add
> dependencies that were previously pulled in as transitive dependencies,
> just to make maven build).
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Review of jackson features
Posted by Steinar Bang <sb...@dod.no>.
>>>>> Łukasz Dywicki <lu...@code-house.org>:
> My points is following - if we need to change scope of maven dependency
> just to force feature generator to create <bundle> entry (or similar)
> then it is better to explicitly declare these in the descriptor manually
> and do not rely on generator for these.
Handling the bundle imports and export manually, would require more work
than I'm willing to put in.
Not only the manual config of maven-bundle-plugin for each jersey
bundle, but also the feature runtime dependencies would have to be
created manually instead of by karaf-maven-plugin.
I think manual maven-bundle-config and manually created features will be
hard to maintain, as well.
Re: Review of jackson features
Posted by Łukasz Dywicki <lu...@code-house.org>.
My points is following - if we need to change scope of maven dependency
just to force feature generator to create <bundle> entry (or similar)
then it is better to explicitly declare these in the descriptor manually
and do not rely on generator for these.
Cheers,
Łukasz
--
Code-House
http://code-house.org
On 28.01.2020 17:02, Steinar Bang wrote:
>>>>>> Łukasz Dywicki <lu...@code-house.org>:
>
>> Scope change is only necessary for feature generator thus we should
>> avoid that to not promote new dependencies to jackson users. This
>> might cause a push back later on as somebody will need to manage
>> dependency brought by new jackson release which he hasn't had before.
>
> Yes, this was my worry.
>
> (on the other hand, some of these dependencies were already
> <scope>provided</scope>, so FWIW it's more consistent in my change
> branch...)
>
>> I believe we can still explicitly define these in feature fragment using
>> <bundle> part and leave maven part.
>
> I don't understand what you mean here.
>
Re: Review of jackson features
Posted by Steinar Bang <sb...@dod.no>.
>>>>> Łukasz Dywicki <lu...@code-house.org>:
> Scope change is only necessary for feature generator thus we should
> avoid that to not promote new dependencies to jackson users. This
> might cause a push back later on as somebody will need to manage
> dependency brought by new jackson release which he hasn't had before.
Yes, this was my worry.
(on the other hand, some of these dependencies were already
<scope>provided</scope>, so FWIW it's more consistent in my change
branch...)
> I believe we can still explicitly define these in feature fragment using
> <bundle> part and leave maven part.
I don't understand what you mean here.
Re: Review of jackson features
Posted by Łukasz Dywicki <lu...@code-house.org>.
Scope change is only necessary for feature generator thus we should avoid
that to not promote new dependencies to jackson users. This might cause a
push back later on as somebody will need to manage dependency brought by
new jackson release which he hasn't had before.
I believe we can still explicitly define these in feature fragment using
<bundle> part and leave maven part.
Cheers,
Łukasz
pon., 27 sty 2020 o 17:17 Steinar Bang <sb...@dod.no> napisał(a):
> >>>>> Łukasz Dywicki <lu...@code-house.org>:
>
> > Hey, as changes were made last year I would not hold it too long. As
> > long as integration doesn't break Jackson build we should be fine. In
> > worst case we will have to raise an issue in jackson issue
> > tracker. ;-)
>
> The changes that I'm most unsure about, are the dependency scope changes
> (I've changed all of the dependencies that are pulled in by features to
> have <scope>provided</scope> and that in turn meant that I've had to add
> dependencies that were previously pulled in as transitive dependencies,
> just to make maven build).
>
>
Re: Review of jackson features
Posted by Steinar Bang <sb...@dod.no>.
>>>>> Łukasz Dywicki <lu...@code-house.org>:
> Hey, as changes were made last year I would not hold it too long. As
> long as integration doesn't break Jackson build we should be fine. In
> worst case we will have to raise an issue in jackson issue
> tracker. ;-)
The changes that I'm most unsure about, are the dependency scope changes
(I've changed all of the dependencies that are pulled in by features to
have <scope>provided</scope> and that in turn meant that I've had to add
dependencies that were previously pulled in as transitive dependencies,
just to make maven build).
Re: Review of jackson features
Posted by Łukasz Dywicki <lu...@code-house.org>.
Hey, as changes were made last year I would not hold it too long. As long as integration doesn't break Jackson build we should be fine. In worst case we will have to raise an issue in jackson issue tracker. ;-)
They are pretty responsive and didn’t make any troubles with fixes in the past so I am not worried about waiting a bit for a patch release from them.
Cheers,
Łukasz Dywicki
--
Code-House
http://code-house.org
> On 21 Jan 2020, at 05:47, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
>
> Hi,
>
> Now that I've submitted 4.2.8 to vote, I will switch back to this one.
>
> Again, sorry for the delay :/
>
> Regards
> JB
>
>> On 20/01/2020 22:27, Steinar Bang wrote:
>> (a small ping on this one...)
>>
>>>>>>> Steinar Bang <sb...@dod.no>:
>>
>>>>>>> Steinar Bang <sb...@dod.no>:
>>>>>>> Jean-Baptiste Onofré <jb...@nanthrax.net>:
>>>>> Hi Steinar,
>>>>> I started to review the different branches
>>>>> (https://github.com/steinarb/jackson-parent/tree/add-apache-karaf-features-to-jackson,
>>>>> ...).
>>
>>>>> I have some comments and improvements.
>>
>>>>> Do you want me to create PR on your branches or do you want to chat on
>>>>> Slack about that ?
>>
>>>>> Please let me know the most convenient for you.
>>
>>>> Thanks, JB! PRs on the branches will be simplest.
>>
>>> Hi JB, any progress on the PRs?
>>
>>> (If you don't have time to make the PRs yourself, and have notes from the
>>> review, you could pass me your notes in an email or here on the list,
>>> and I will make the PRs and run them past you to see if I've understood
>>> the notes)
>>
>>> Thanks!
>>
>>
>>> - Steinar
>>
>>
>>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
Re: Review of jackson features
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi,
Now that I've submitted 4.2.8 to vote, I will switch back to this one.
Again, sorry for the delay :/
Regards
JB
On 20/01/2020 22:27, Steinar Bang wrote:
> (a small ping on this one...)
>
>>>>>> Steinar Bang <sb...@dod.no>:
>
>>>>>> Steinar Bang <sb...@dod.no>:
>>>>>> Jean-Baptiste Onofré <jb...@nanthrax.net>:
>>>> Hi Steinar,
>>>> I started to review the different branches
>>>> (https://github.com/steinarb/jackson-parent/tree/add-apache-karaf-features-to-jackson,
>>>> ...).
>
>>>> I have some comments and improvements.
>
>>>> Do you want me to create PR on your branches or do you want to chat on
>>>> Slack about that ?
>
>>>> Please let me know the most convenient for you.
>
>>> Thanks, JB! PRs on the branches will be simplest.
>
>> Hi JB, any progress on the PRs?
>
>> (If you don't have time to make the PRs yourself, and have notes from the
>> review, you could pass me your notes in an email or here on the list,
>> and I will make the PRs and run them past you to see if I've understood
>> the notes)
>
>> Thanks!
>
>
>> - Steinar
>
>
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Review of jackson features
Posted by Steinar Bang <sb...@dod.no>.
(a small ping on this one...)
>>>>> Steinar Bang <sb...@dod.no>:
>>>>> Steinar Bang <sb...@dod.no>:
>>>>> Jean-Baptiste Onofré <jb...@nanthrax.net>:
>>> Hi Steinar,
>>> I started to review the different branches
>>> (https://github.com/steinarb/jackson-parent/tree/add-apache-karaf-features-to-jackson,
>>> ...).
>>> I have some comments and improvements.
>>> Do you want me to create PR on your branches or do you want to chat on
>>> Slack about that ?
>>> Please let me know the most convenient for you.
>> Thanks, JB! PRs on the branches will be simplest.
> Hi JB, any progress on the PRs?
> (If you don't have time to make the PRs yourself, and have notes from the
> review, you could pass me your notes in an email or here on the list,
> and I will make the PRs and run them past you to see if I've understood
> the notes)
> Thanks!
> - Steinar
Re: Review of jackson features
Posted by Steinar Bang <sb...@dod.no>.
>>>>> Steinar Bang <sb...@dod.no>:
>>>>> Jean-Baptiste Onofré <jb...@nanthrax.net>:
>> Hi Steinar,
>> I started to review the different branches
>> (https://github.com/steinarb/jackson-parent/tree/add-apache-karaf-features-to-jackson,
>> ...).
>> I have some comments and improvements.
>> Do you want me to create PR on your branches or do you want to chat on
>> Slack about that ?
>> Please let me know the most convenient for you.
> Thanks, JB! PRs on the branches will be simplest.
Hi JB, any progress on the PRs?
(If you don't have time to make the PRs yourself, and have notes from the
review, you could pass me your notes in an email or here on the list,
and I will make the PRs and run them past you to see if I've understood
the notes)
Thanks!
- Steinar
Re: Review of jackson features
Posted by Steinar Bang <sb...@dod.no>.
>>>>> Jean-Baptiste Onofré <jb...@nanthrax.net>:
> Hi Steinar,
> I started to review the different branches
> (https://github.com/steinarb/jackson-parent/tree/add-apache-karaf-features-to-jackson,
> ...).
> I have some comments and improvements.
> Do you want me to create PR on your branches or do you want to chat on
> Slack about that ?
> Please let me know the most convenient for you.
Thanks, JB! PRs on the branches will be simplest.
Re: Review of jackson features
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Steinar,
I started to review the different branches
(https://github.com/steinarb/jackson-parent/tree/add-apache-karaf-features-to-jackson,
...).
I have some comments and improvements.
Do you want me to create PR on your branches or do you want to chat on
Slack about that ?
Please let me know the most convenient for you.
Thanks,
Regards
JB
On 18/11/2019 23:38, Steinar Bang wrote:
>>>>>> Jean-Baptiste Onofré <jb...@nanthrax.net>:
>
>> Hi Steinar,
>> I'm on it tonight.
>
> Hi, again JB! Great! Thanks! :-)
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Review of jackson features
Posted by Steinar Bang <sb...@dod.no>.
>>>>> Jean-Baptiste Onofré <jb...@nanthrax.net>:
> Hi Steinar,
> I'm on it tonight.
Hi, again JB! Great! Thanks! :-)
Re: Review of jackson features
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Steinar,
I'm on it tonight.
Regards
JB
On 18/11/2019 19:10, Steinar Bang wrote:
>>>>>> Steinar Bang <sb...@dod.no>:
>
>>>>>> Steinar Bang <sb...@dod.no>:
>>>> Thanks for the update.
>>>> I will do a pass this afternoon.
>
>>> Hi, JB! Did you see anything that needs fixing?
>
>> Hi again, JB! Have you had time to look at this?
>
> (If you don't have time then I can just make a set of PRs from what I have...)
>
>
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Review of jackson features
Posted by Steinar Bang <sb...@dod.no>.
>>>>> Steinar Bang <sb...@dod.no>:
>>>>> Steinar Bang <sb...@dod.no>:
>>> Thanks for the update.
>>> I will do a pass this afternoon.
>> Hi, JB! Did you see anything that needs fixing?
> Hi again, JB! Have you had time to look at this?
(If you don't have time then I can just make a set of PRs from what I have...)
Re: Review of jackson features
Posted by Steinar Bang <sb...@dod.no>.
>>>>> Steinar Bang <sb...@dod.no>:
>> Thanks for the update.
>> I will do a pass this afternoon.
> Hi, JB! Did you see anything that needs fixing?
Hi again, JB! Have you had time to look at this?
Re: Review of jackson features
Posted by Steinar Bang <sb...@dod.no>.
>>>>> Jean-Baptiste Onofré <jb...@nanthrax.net>:
> Thanks for the update.
> I will do a pass this afternoon.
Hi, JB! Did you see anything that needs fixing?
Re: Review of jackson features
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Thanks for the update.
I will do a pass this afternoon.
Regards
JB
On 19/10/2019 07:58, Steinar Bang wrote:
>>>>>> Jean-Baptiste Onofré <jb...@nanthrax.net>:
>> On 08/10/2019 18:29, Steinar Bang wrote:
>
>> Thanks for the update. I will take a look on the rebase then.
>
>>> Note! The jackson 2.10 train has gone and the 2.11 branches are
>>> available, so I will start rebasing the fix branches on 2.11.
>
> @JB The rebase on jackson 2.11 (version number 2.11.0-SNAPSHOT) is
> complete.
>
> All features have been test-loaded on karaf 4.2.7 running on openjdk-11
> on debian 10 "buster" on amd64.
>
> The test procedure, was
> 1. Delete the karaf data directory
> 2. Start karaf
> 3. Load the feature repository:
> feature:repo-add mvn:com.fasterxml.jackson/karaf/LATEST/xml/features
> 4. Load the feature under test, e.g.
> feature:install jackson-core
> 5. Check what was loaded with:
> bundle:list
> 6. Repeat the procedure for a new feature, i.e. replace "jackson-core"
> in the example above with a new feature (there was a *lot* of
> features to test...:-) )
> The artifactId of each bundle becomes the karaf feature name
>
> Note: I have done all of my building on openjdk-11, but jackson is built
> for release with java-8. This means that there are some extra commits
> with java-9+ build fixes before the actual feature related commits on
> some of the branches (I had to make things build on my system before I
> could do the changes).
>
> Here's a summary of the changes:
> 1. jackson-parent:
> Issue: https://github.com/FasterXML/jackson-parent/issues/11
> git branch: https://github.com/steinarb/jackson-parent/tree/add-apache-karaf-features-to-jackson
> Contains karaf-maven-plugin configuration in pluginManagement:
> - Uses karaf 4.2.6
> - Binds feature-generate-descriptor to the package phase
> - includeTransitiveDependency: false
> - aggregateFeatures: false
> - includeProjectArtifact: true
>
> 2. jackson-bom:
> Issue: https://github.com/FasterXML/jackson-bom/issues/27
> git branch: https://github.com/steinarb/jackson-bom/tree/add-apache-karaf-features-to-jackson
> Changes:
> - Use snapshot versions for everything (without this the branch
> won't build)
> - Add a module that attaches a hand-written master feature
> repository that will load all jersey feature repositories
>
> 3. jackson-annotations
> Issue: https://github.com/FasterXML/jackson-annotations/issues/160
> git branch: https://github.com/steinarb/jackson-annotations/tree/add-apache-karaf-features-to-jackson
> Changes:
> - Use snapshot for the parent version
> - Reference the karaf-maven-plugin in the plugins section
>
> 4. jackson-core
> Issue: https://github.com/FasterXML/jackson-core/issues/560
> git branch: https://github.com/steinarb/jackson-core/tree/add-apache-karaf-features-to-jackson
> Changes:
> - Reference the karaf-maven-plugin in the plugins section
>
> 5. jackson-databind
> Issue: https://github.com/FasterXML/jackson-databind/issues/2434 (this is also the initial issue I created)
> git branch: https://github.com/steinarb/jackson-databind/tree/add-apache-karaf-features-to-jackson
> Changes:
> - Reference the karaf-maven-plugin in the plugins section
> - Make the jackson-annotation and jackson-core maven dependencies provided
> - Add a template feature.xml depending on the jackson-annotation and jackson-core features
>
> 6. jackson-modules-base
> Issue: https://github.com/FasterXML/jackson-modules-base/issues/86
> git branch: https://github.com/steinarb/jackson-modules-base/tree/add-apache-karaf-features-to-jackson
> Changes in each of the modules:
> - Reference the karaf-maven-plugin in the plugins section
> - Make the jackson-annotation and/or jackson-core and/or jackson-databind
> maven dependencies provided
> - Add a template feature.xml depending on the jackson-databind
> feature (or just jackson-core and jackson-annotations for the
> mrbean module)
> - In guice:
> - change config includeTransitiveDependency to true
> - exclude javax.inject to avoid wrapping javax.inject in the
> jackson-module-guice feature (a wrapped javax.inject will break
> jersey)
> - add javax.inject as a provided dependency (so that things will
> compile)
> - depend on the built-in feature transaction-api, to get
> javax.inject from a properly versioned OSGi bundle
>
> 7. jackson-datatypes-collections
> Issue: https://github.com/FasterXML/jackson-datatypes-collections/issues/59
> git branch: https://github.com/steinarb/jackson-datatypes-collections/tree/add-apache-karaf-features-to-jackson
> Changes:
> - In the parent pom, make jackson-annotations, jackson-core and
> jackson-databind be provided dependencies
> - In all modules
> - Reference the karaf-maven-plugin in the plugins section
> - Add a template feature.xml depending on the jackson-databind feature
> - In the pcollections module change packaging from jar to bundle
> - In the eclipse-collections module include eclipse-collections as
> a wrapped module in the template feature.xml (strange that wrap
> was needed for an eclipse file...? The manifest of the
> eclipse-collections jar was weird... possible duplicated line
> breaks)
>
> 8. jackson-dataformats-binary
> Issue: https://github.com/FasterXML/jackson-dataformats-binary/issues/181
> git branch: https://github.com/steinarb/jackson-dataformats-binary/tree/add-apache-karaf-features-to-jackson
> Changes:
> - Make jackson-core provided in the top pom
> - In the submodules:
> - Reference the karaf-maven-plugin in the plugins section
> - Add a template feature.xml pulling in jackson-databind
> - In the avro module
> - set includeTransitiveDependency to true
> - make jackson-databind and jackson-annotations provided
> - exclude guava and slf4j-api transitive dependencies
> - Note: avro has dependecies to jars in an old version of jackson
> See issue: https://github.com/FasterXML/jackson-dataformats-binary/issues/167
>
> 9. jackson-dataformat-xml
> Issue: https://github.com/FasterXML/jackson-dataformat-xml/issues/361
> git branch: https://github.com/steinarb/jackson-dataformat-xml/tree/add-apache-karaf-features-to-jackson
> Changes:
> - Reference the karaf-maven-plugin in the plugins section
> - Make jackson-annotation, jackson-core and jackson-databind provided
> - In the template feature.xml:
> - Depend on the jackson-module-jaxb-annotations feature
> - wrap the relaxngDatatype jar and load it as a bundle
>
> 10. jackson-datatype-hibernate
> Issue: https://github.com/FasterXML/jackson-datatype-hibernate/issues/132
> git branch: https://github.com/steinarb/jackson-datatype-hibernate/tree/add-apache-karaf-features-to-jackson
> Changes:
> - Fix some openjdk-11 test startup issues
> - In the parent pom, make jackson-annotations, jackson-core and
> jackson-databind be provided dependencies
> - In the sub-modules:
> - Reference the karaf-maven-plugin in the plugins section
> - Add a template karaf.xml that
> - Reference the jackson-databind feature
> - Reference the built-in hibernate feature
> - (The features all load, but I'm guessing the hibernate5 feature
> will be the only one actually working)
>
> 11. jackson-dataformats-text
> Issue: https://github.com/FasterXML/jackson-dataformats-text/issues/144
> git branch: https://github.com/steinarb/jackson-dataformats-text/tree/add-apache-karaf-features-to-jackson
> Changes:
> - Make jackson-core provided in the parent pom
> - In the modules:
> - Reference the karaf-maven-plugin in the plugins section
> - Add a template feature.xml referencing jackson-databind
>
> 12. jackson-datatype-joda
> Issue: https://github.com/FasterXML/jackson-datatype-joda/issues/107
> git branch: https://github.com/steinarb/jackson-datatype-joda/tree/add-apache-karaf-features-to-jackson
> Changes:
> - Reference the karaf-maven-plugin in the plugins section
> - Make jackson-annotations, jackson-core and jackson-databind provided
> - Add a template feature.xml referencing jackson-databind
>
> 13. jackson-datatype-json-org
> Issue: https://github.com/FasterXML/jackson-datatype-json-org/issues/16
> git branch: https://github.com/steinarb/jackson-datatype-json-org/tree/add-apache-karaf-features-to-jackson
> Changes:
> - Reference the karaf-maven-plugin in the plugins section
> - Make jackson-core and jackson-databind provided
> - Add a template feature.xml referencing jackson-databind
>
> 14. jackson-datatype-jsr353
> Issue: https://github.com/FasterXML/jackson-datatype-jsr353/issues/12
> git branch: https://github.com/steinarb/jackson-datatype-jsr353/tree/add-apache-karaf-features-to-jackson
> Changes:
> - Reference the karaf-maven-plugin in the plugins section
> - Make jackson-core and jackson-databind provided
> - Add a template feature.xml referencing jackson-databind
>
> 15. jackson-jaxrs-providers
> Issue: https://github.com/FasterXML/jackson-jaxrs-providers/issues/115
> git branch: https://github.com/steinarb/jackson-jaxrs-providers/tree/add-apache-karaf-features-to-jackson
> Changes
> - non-releated build change: I had to change the port number of the
> tests from 6011 t0 60110 because port 6011 collided with a port
> used by ssh X11 port forwarding (ie. not releated to openjdk-11
> but to my development system)
> - Too many to list (at this time of night), but basically
> - Reference the karaf-maven-plugin in the plugins section
> - Make jackson-* maven dependencies provided
> - Add a template feature.xml referencing the jackson-* features
> matching the maven dependencies made provided
>
> 16. jackson-jr
> Issue: https://github.com/FasterXML/jackson-jr/issues/67
> git branch: https://github.com/steinarb/jackson-jr/tree/add-apache-karaf-features-to-jackson
> Changes
> - Reference the karaf-maven-plugin in the plugins section
> - Make the jackson-* dependencies provided
> - Reference the features matching the dependencies made provided in
> the template feature.xml
>
> 17. jackson-module-jsonSchema
> Issue: https://github.com/FasterXML/jackson-module-jsonSchema/issues/138
> git branch: https://github.com/steinarb/jackson-module-jsonSchema/tree/add-apache-karaf-features-to-jackson
> Changes
> - Reference the karaf-maven-plugin in the plugins section
> - Make the jackson-* dependencies provided
> - Reference the features matching the dependencies made provided in
> the template feature.xml
>
> 18. jackson-modules-java8
> Issue: https://github.com/FasterXML/jackson-modules-java8/issues/137
> git branch: https://github.com/steinarb/jackson-modules-java8/tree/add-apache-karaf-features-to-jackson
> Changes
> - Remove the -Werror flag on two projects, because compiling with
> openjdk-11 gave a warning that broke the build
> - Reference the karaf-maven-plugin in the plugins section
> - Make the jackson-* dependencies provided
> - Reference the features matching the dependencies made provided in
> the template feature.xml
>
> 19. jacskon-module-kotlin
> Issue: https://github.com/FasterXML/jackson-module-kotlin/issues/248
> git branch: https://github.com/steinarb/jackson-module-kotlin/tree/add-apache-karaf-features-to-jackson
> Changes
> - Reference the karaf-maven-plugin in the plugins section
> - Make the jackson-* dependencies provided
> - Reference the features matching the dependencies made provided in
> the template feature.xml
>
> 20. jackson-module-scala
> Issue: https://github.com/FasterXML/jackson-module-scala/issues/427
> (no idea how to do this one, it's not using maven)
> (still no idea how to do this one)
>
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Review of jackson features
Posted by Steinar Bang <sb...@dod.no>.
>>>>> Jean-Baptiste Onofré <jb...@nanthrax.net>:
> On 08/10/2019 18:29, Steinar Bang wrote:
> Thanks for the update. I will take a look on the rebase then.
>> Note! The jackson 2.10 train has gone and the 2.11 branches are
>> available, so I will start rebasing the fix branches on 2.11.
@JB The rebase on jackson 2.11 (version number 2.11.0-SNAPSHOT) is
complete.
All features have been test-loaded on karaf 4.2.7 running on openjdk-11
on debian 10 "buster" on amd64.
The test procedure, was
1. Delete the karaf data directory
2. Start karaf
3. Load the feature repository:
feature:repo-add mvn:com.fasterxml.jackson/karaf/LATEST/xml/features
4. Load the feature under test, e.g.
feature:install jackson-core
5. Check what was loaded with:
bundle:list
6. Repeat the procedure for a new feature, i.e. replace "jackson-core"
in the example above with a new feature (there was a *lot* of
features to test...:-) )
The artifactId of each bundle becomes the karaf feature name
Note: I have done all of my building on openjdk-11, but jackson is built
for release with java-8. This means that there are some extra commits
with java-9+ build fixes before the actual feature related commits on
some of the branches (I had to make things build on my system before I
could do the changes).
Here's a summary of the changes:
1. jackson-parent:
Issue: https://github.com/FasterXML/jackson-parent/issues/11
git branch: https://github.com/steinarb/jackson-parent/tree/add-apache-karaf-features-to-jackson
Contains karaf-maven-plugin configuration in pluginManagement:
- Uses karaf 4.2.6
- Binds feature-generate-descriptor to the package phase
- includeTransitiveDependency: false
- aggregateFeatures: false
- includeProjectArtifact: true
2. jackson-bom:
Issue: https://github.com/FasterXML/jackson-bom/issues/27
git branch: https://github.com/steinarb/jackson-bom/tree/add-apache-karaf-features-to-jackson
Changes:
- Use snapshot versions for everything (without this the branch
won't build)
- Add a module that attaches a hand-written master feature
repository that will load all jersey feature repositories
3. jackson-annotations
Issue: https://github.com/FasterXML/jackson-annotations/issues/160
git branch: https://github.com/steinarb/jackson-annotations/tree/add-apache-karaf-features-to-jackson
Changes:
- Use snapshot for the parent version
- Reference the karaf-maven-plugin in the plugins section
4. jackson-core
Issue: https://github.com/FasterXML/jackson-core/issues/560
git branch: https://github.com/steinarb/jackson-core/tree/add-apache-karaf-features-to-jackson
Changes:
- Reference the karaf-maven-plugin in the plugins section
5. jackson-databind
Issue: https://github.com/FasterXML/jackson-databind/issues/2434 (this is also the initial issue I created)
git branch: https://github.com/steinarb/jackson-databind/tree/add-apache-karaf-features-to-jackson
Changes:
- Reference the karaf-maven-plugin in the plugins section
- Make the jackson-annotation and jackson-core maven dependencies provided
- Add a template feature.xml depending on the jackson-annotation and jackson-core features
6. jackson-modules-base
Issue: https://github.com/FasterXML/jackson-modules-base/issues/86
git branch: https://github.com/steinarb/jackson-modules-base/tree/add-apache-karaf-features-to-jackson
Changes in each of the modules:
- Reference the karaf-maven-plugin in the plugins section
- Make the jackson-annotation and/or jackson-core and/or jackson-databind
maven dependencies provided
- Add a template feature.xml depending on the jackson-databind
feature (or just jackson-core and jackson-annotations for the
mrbean module)
- In guice:
- change config includeTransitiveDependency to true
- exclude javax.inject to avoid wrapping javax.inject in the
jackson-module-guice feature (a wrapped javax.inject will break
jersey)
- add javax.inject as a provided dependency (so that things will
compile)
- depend on the built-in feature transaction-api, to get
javax.inject from a properly versioned OSGi bundle
7. jackson-datatypes-collections
Issue: https://github.com/FasterXML/jackson-datatypes-collections/issues/59
git branch: https://github.com/steinarb/jackson-datatypes-collections/tree/add-apache-karaf-features-to-jackson
Changes:
- In the parent pom, make jackson-annotations, jackson-core and
jackson-databind be provided dependencies
- In all modules
- Reference the karaf-maven-plugin in the plugins section
- Add a template feature.xml depending on the jackson-databind feature
- In the pcollections module change packaging from jar to bundle
- In the eclipse-collections module include eclipse-collections as
a wrapped module in the template feature.xml (strange that wrap
was needed for an eclipse file...? The manifest of the
eclipse-collections jar was weird... possible duplicated line
breaks)
8. jackson-dataformats-binary
Issue: https://github.com/FasterXML/jackson-dataformats-binary/issues/181
git branch: https://github.com/steinarb/jackson-dataformats-binary/tree/add-apache-karaf-features-to-jackson
Changes:
- Make jackson-core provided in the top pom
- In the submodules:
- Reference the karaf-maven-plugin in the plugins section
- Add a template feature.xml pulling in jackson-databind
- In the avro module
- set includeTransitiveDependency to true
- make jackson-databind and jackson-annotations provided
- exclude guava and slf4j-api transitive dependencies
- Note: avro has dependecies to jars in an old version of jackson
See issue: https://github.com/FasterXML/jackson-dataformats-binary/issues/167
9. jackson-dataformat-xml
Issue: https://github.com/FasterXML/jackson-dataformat-xml/issues/361
git branch: https://github.com/steinarb/jackson-dataformat-xml/tree/add-apache-karaf-features-to-jackson
Changes:
- Reference the karaf-maven-plugin in the plugins section
- Make jackson-annotation, jackson-core and jackson-databind provided
- In the template feature.xml:
- Depend on the jackson-module-jaxb-annotations feature
- wrap the relaxngDatatype jar and load it as a bundle
10. jackson-datatype-hibernate
Issue: https://github.com/FasterXML/jackson-datatype-hibernate/issues/132
git branch: https://github.com/steinarb/jackson-datatype-hibernate/tree/add-apache-karaf-features-to-jackson
Changes:
- Fix some openjdk-11 test startup issues
- In the parent pom, make jackson-annotations, jackson-core and
jackson-databind be provided dependencies
- In the sub-modules:
- Reference the karaf-maven-plugin in the plugins section
- Add a template karaf.xml that
- Reference the jackson-databind feature
- Reference the built-in hibernate feature
- (The features all load, but I'm guessing the hibernate5 feature
will be the only one actually working)
11. jackson-dataformats-text
Issue: https://github.com/FasterXML/jackson-dataformats-text/issues/144
git branch: https://github.com/steinarb/jackson-dataformats-text/tree/add-apache-karaf-features-to-jackson
Changes:
- Make jackson-core provided in the parent pom
- In the modules:
- Reference the karaf-maven-plugin in the plugins section
- Add a template feature.xml referencing jackson-databind
12. jackson-datatype-joda
Issue: https://github.com/FasterXML/jackson-datatype-joda/issues/107
git branch: https://github.com/steinarb/jackson-datatype-joda/tree/add-apache-karaf-features-to-jackson
Changes:
- Reference the karaf-maven-plugin in the plugins section
- Make jackson-annotations, jackson-core and jackson-databind provided
- Add a template feature.xml referencing jackson-databind
13. jackson-datatype-json-org
Issue: https://github.com/FasterXML/jackson-datatype-json-org/issues/16
git branch: https://github.com/steinarb/jackson-datatype-json-org/tree/add-apache-karaf-features-to-jackson
Changes:
- Reference the karaf-maven-plugin in the plugins section
- Make jackson-core and jackson-databind provided
- Add a template feature.xml referencing jackson-databind
14. jackson-datatype-jsr353
Issue: https://github.com/FasterXML/jackson-datatype-jsr353/issues/12
git branch: https://github.com/steinarb/jackson-datatype-jsr353/tree/add-apache-karaf-features-to-jackson
Changes:
- Reference the karaf-maven-plugin in the plugins section
- Make jackson-core and jackson-databind provided
- Add a template feature.xml referencing jackson-databind
15. jackson-jaxrs-providers
Issue: https://github.com/FasterXML/jackson-jaxrs-providers/issues/115
git branch: https://github.com/steinarb/jackson-jaxrs-providers/tree/add-apache-karaf-features-to-jackson
Changes
- non-releated build change: I had to change the port number of the
tests from 6011 t0 60110 because port 6011 collided with a port
used by ssh X11 port forwarding (ie. not releated to openjdk-11
but to my development system)
- Too many to list (at this time of night), but basically
- Reference the karaf-maven-plugin in the plugins section
- Make jackson-* maven dependencies provided
- Add a template feature.xml referencing the jackson-* features
matching the maven dependencies made provided
16. jackson-jr
Issue: https://github.com/FasterXML/jackson-jr/issues/67
git branch: https://github.com/steinarb/jackson-jr/tree/add-apache-karaf-features-to-jackson
Changes
- Reference the karaf-maven-plugin in the plugins section
- Make the jackson-* dependencies provided
- Reference the features matching the dependencies made provided in
the template feature.xml
17. jackson-module-jsonSchema
Issue: https://github.com/FasterXML/jackson-module-jsonSchema/issues/138
git branch: https://github.com/steinarb/jackson-module-jsonSchema/tree/add-apache-karaf-features-to-jackson
Changes
- Reference the karaf-maven-plugin in the plugins section
- Make the jackson-* dependencies provided
- Reference the features matching the dependencies made provided in
the template feature.xml
18. jackson-modules-java8
Issue: https://github.com/FasterXML/jackson-modules-java8/issues/137
git branch: https://github.com/steinarb/jackson-modules-java8/tree/add-apache-karaf-features-to-jackson
Changes
- Remove the -Werror flag on two projects, because compiling with
openjdk-11 gave a warning that broke the build
- Reference the karaf-maven-plugin in the plugins section
- Make the jackson-* dependencies provided
- Reference the features matching the dependencies made provided in
the template feature.xml
19. jacskon-module-kotlin
Issue: https://github.com/FasterXML/jackson-module-kotlin/issues/248
git branch: https://github.com/steinarb/jackson-module-kotlin/tree/add-apache-karaf-features-to-jackson
Changes
- Reference the karaf-maven-plugin in the plugins section
- Make the jackson-* dependencies provided
- Reference the features matching the dependencies made provided in
the template feature.xml
20. jackson-module-scala
Issue: https://github.com/FasterXML/jackson-module-scala/issues/427
(no idea how to do this one, it's not using maven)
(still no idea how to do this one)
Re: Review of jackson features
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Steinar,
Thanks for the update. I will take a look on the rebase then.
Sorry for the delay.
Regards
JB
On 08/10/2019 18:29, Steinar Bang wrote:
> Note! The jackson 2.10 train has gone and the 2.11 branches are
> available, so I will start rebasing the fix branches on 2.11.
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Review of jackson features
Posted by Steinar Bang <sb...@dod.no>.
Note! The jackson 2.10 train has gone and the 2.11 branches are
available, so I will start rebasing the fix branches on 2.11.