[GitHub] [airflow] potiuk commented on a change in pull request #7091: [AIRFLOW-6489] Separate integrations in tests

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #7091: [AIRFLOW-6489] Separate integrations in tests
URL: https://github.com/apache/airflow/pull/7091#discussion_r365785103
 
 

 ##########
 File path: scripts/ci/in_container/_in_container_utils.sh
 ##########
 @@ -195,4 +195,5 @@ EOF
 
 function stop_output_heartbeat() {
     kill "${HEARTBEAT_PID}"
+    wait "${HEARTBEAT_PID}" || true 2> /dev/null
 
 Review comment:
   Kill %1 is the same as PID but it is really intended for interactive use (when you see the output of `jobs` command). You never know which job you are killing this way.  If you have some other background jobs started before your  "start_output_heartbeat" then `kill %1` will kill the other job, not the heartbeat. Storing PID of the started process and using it explicitly is the only sure way I know to kill exactly the process I intend to.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services