[jira] [Updated] (SOLR-9014) Deprecate and reduce usage of ClusterState methods which may make calls to ZK via the lazy collection reference

["Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-9014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar updated SOLR-9014:
----------------------------------------
    Attachment: SOLR-9014-deprecate-getCollections.patch

# Deprecates the ClusterState.getCollections method and introduces a new getCollectionsMap method.
# Removes a redundant call at ZkController.publishAndWaitForDownStates 
# Fixed SQLHandler.open which called getCollections twice, once to get size and then again to actually get the set of collection names

As I said earlier this change trips SOLR-9030 a lot more. I'll fix that issue first before I commit this patch.


> Deprecate and reduce usage of ClusterState methods which may make calls to ZK via the lazy collection reference
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-9014
>                 URL: https://issues.apache.org/jira/browse/SOLR-9014
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: Shalin Shekhar Mangar
>             Fix For: 6.1, master
>
>         Attachments: SOLR-9014-deprecate-getCollections.patch, SOLR-9014.patch
>
>
> ClusterState has a bunch of methods such as getSlice and getReplica which internally call getCollectionOrNull that ends up making a call to ZK via the lazy collection reference. Many classes use these methods even though a DocCollection object is available. In such cases, multiple redundant calls to ZooKeeper can happen if the collection is not watched locally. This is especially true for Overseer classes which operate on all collections.
> We should audit all usages of these methods and replace them with calls to appropriate DocCollection methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org