[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #11601: add default sharding column

[GitBox <gi...@apache.org>]

strongduanmu commented on a change in pull request #11601:
URL: https://github.com/apache/shardingsphere/pull/11601#discussion_r680788541



##########
File path: shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/env/db/rules.yaml
##########
@@ -22,7 +22,6 @@ rules:
       actualDataNodes: db_${0..9}.t_order
       databaseStrategy:
         standard:
-          shardingColumn: user_id

Review comment:
       @tuichenchuxin Why delete this config?

##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/route/strategy/ShardingStrategyFactoryTest.java
##########
@@ -59,14 +59,14 @@
     @Test
     public void assertNewInstance() {
         when(standardShardingStrategyConfiguration.getShardingColumn()).thenReturn("standard_sharding_column");
-        ShardingStrategy actualStandardShardingStrategy = ShardingStrategyFactory.newInstance(standardShardingStrategyConfiguration, standardShardingAlgorithmFixture);
+        ShardingStrategy actualStandardShardingStrategy = ShardingStrategyFactory.newInstance(standardShardingStrategyConfiguration, standardShardingAlgorithmFixture, null);

Review comment:
       @tuichenchuxin Please add more test cases.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org