You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Ivan (JIRA)" <ji...@apache.org> on 2009/09/02 07:58:32 UTC

[jira] Created: (GERONIMO-4836) A uniform way to handle semicolon in Tomcat/Pluto

A uniform way to handle semicolon in Tomcat/Pluto
-------------------------------------------------

                 Key: GERONIMO-4836
                 URL: https://issues.apache.org/jira/browse/GERONIMO-4836
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: console, Tomcat
    Affects Versions: 2.2
            Reporter: Ivan


While the input parameter contains semicolon, there will be some issues while handlering those parameters. Seem that Pluto would ignore those parameters after the semicolon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-4836) Default Pluto URL parser could not hanle semicolon in the parameter values

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758954#action_12758954 ] 

David Jencks commented on GERONIMO-4836:
----------------------------------------

I applied a slightly modified patch to pluto branches-1.1.x (modified to work with jdk 1.4) and asked on the pluto dev list about applying it to pluto trunk.

Meanwhile we should get this into geronimo.  I looked, we can just copy the modified class into geronimo, change the package to a geronimo one, and change the spring configuration to use it instead of the original pluto one.  If there's any doubt about how to do this just ask...

thanks!


> Default Pluto URL parser could not hanle semicolon in the parameter values
> --------------------------------------------------------------------------
>
>                 Key: GERONIMO-4836
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4836
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console, Tomcat
>    Affects Versions: 2.2
>            Reporter: Ivan
>            Assignee: Ivan
>             Fix For: 2.2
>
>
> While the input parameter contains semicolon, there will be some issues while handlering those parameters. Seem that Pluto would ignore those parameters after the semicolon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GERONIMO-4836) Default Pluto URL parser could not hanle semicolon in the parameter values

Posted by "Ivan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan reassigned GERONIMO-4836:
------------------------------

    Assignee: Ivan

> Default Pluto URL parser could not hanle semicolon in the parameter values
> --------------------------------------------------------------------------
>
>                 Key: GERONIMO-4836
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4836
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console, Tomcat
>    Affects Versions: 2.2
>            Reporter: Ivan
>            Assignee: Ivan
>             Fix For: 2.2
>
>
> While the input parameter contains semicolon, there will be some issues while handlering those parameters. Seem that Pluto would ignore those parameters after the semicolon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-4836) A uniform way to handle semicolon in Tomcat/Pluto

Posted by "Ivan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan updated GERONIMO-4836:
---------------------------

    Fix Version/s: 2.2

> A uniform way to handle semicolon in Tomcat/Pluto
> -------------------------------------------------
>
>                 Key: GERONIMO-4836
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4836
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console, Tomcat
>    Affects Versions: 2.2
>            Reporter: Ivan
>             Fix For: 2.2
>
>
> While the input parameter contains semicolon, there will be some issues while handlering those parameters. Seem that Pluto would ignore those parameters after the semicolon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-4836) A uniform way to handle semicolon in Tomcat/Pluto

Posted by "Ivan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750337#action_12750337 ] 

Ivan commented on GERONIMO-4836:
--------------------------------

My way is to use a filter to wrap the RenderRequest and ActionResponse object to do the encoding, any comment ?

> A uniform way to handle semicolon in Tomcat/Pluto
> -------------------------------------------------
>
>                 Key: GERONIMO-4836
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4836
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console, Tomcat
>    Affects Versions: 2.2
>            Reporter: Ivan
>
> While the input parameter contains semicolon, there will be some issues while handlering those parameters. Seem that Pluto would ignore those parameters after the semicolon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GERONIMO-4836) Default Pluto URL parser could not hanle semicolon in the parameter values

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Jencks closed GERONIMO-4836.
----------------------------------

    Resolution: Fixed

This is fixed in geronimo, working with pluto folks for a better fix there.

> Default Pluto URL parser could not hanle semicolon in the parameter values
> --------------------------------------------------------------------------
>
>                 Key: GERONIMO-4836
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4836
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console, Tomcat
>    Affects Versions: 2.2
>            Reporter: Ivan
>            Assignee: Ivan
>             Fix For: 2.2
>
>
> While the input parameter contains semicolon, there will be some issues while handlering those parameters. Seem that Pluto would ignore those parameters after the semicolon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-4836) A uniform way to handle semicolon in Tomcat/Pluto

Posted by "Ivan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750829#action_12750829 ] 

Ivan commented on GERONIMO-4836:
--------------------------------

I created a JIRA for Pluto https://issues.apache.org/jira/browse/PLUTO-579, and attach a patch for it.

> A uniform way to handle semicolon in Tomcat/Pluto
> -------------------------------------------------
>
>                 Key: GERONIMO-4836
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4836
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console, Tomcat
>    Affects Versions: 2.2
>            Reporter: Ivan
>
> While the input parameter contains semicolon, there will be some issues while handlering those parameters. Seem that Pluto would ignore those parameters after the semicolon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-4836) Default Pluto URL parser could not hanle semicolon in the parameter values

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758957#action_12758957 ] 

David Jencks commented on GERONIMO-4836:
----------------------------------------

Oops, you are ahead of me with porting it into 2.2 :-)  thanks!

> Default Pluto URL parser could not hanle semicolon in the parameter values
> --------------------------------------------------------------------------
>
>                 Key: GERONIMO-4836
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4836
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console, Tomcat
>    Affects Versions: 2.2
>            Reporter: Ivan
>            Assignee: Ivan
>             Fix For: 2.2
>
>
> While the input parameter contains semicolon, there will be some issues while handlering those parameters. Seem that Pluto would ignore those parameters after the semicolon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-4836) A uniform way to handle semicolon in Tomcat/Pluto

Posted by "Ivan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750431#action_12750431 ] 

Ivan commented on GERONIMO-4836:
--------------------------------

OOps, just find we are using Portlet 1.0, we could not define PortletFilter.

> A uniform way to handle semicolon in Tomcat/Pluto
> -------------------------------------------------
>
>                 Key: GERONIMO-4836
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4836
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console, Tomcat
>    Affects Versions: 2.2
>            Reporter: Ivan
>
> While the input parameter contains semicolon, there will be some issues while handlering those parameters. Seem that Pluto would ignore those parameters after the semicolon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-4836) Default Pluto URL parser could not hanle semicolon in the parameter values

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754441#action_12754441 ] 

David Jencks commented on GERONIMO-4836:
----------------------------------------

As I noted in the pluto jira, I think there must be a way to only scan through the string once, using a more complicated regular expression.
I can commit this into pluto but I don't think we can get a new pluto 1.x release for g. 2.2  I guess we need to check the situation in pluto 2.x also. 
If at all possible we should look for a way to fix this in geronimo for 2.2.  Is there any way to put the implementation in plugins/pluto/geronimo-pluto and get pluto-driver to use it?

> Default Pluto URL parser could not hanle semicolon in the parameter values
> --------------------------------------------------------------------------
>
>                 Key: GERONIMO-4836
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4836
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console, Tomcat
>    Affects Versions: 2.2
>            Reporter: Ivan
>             Fix For: 2.2
>
>
> While the input parameter contains semicolon, there will be some issues while handlering those parameters. Seem that Pluto would ignore those parameters after the semicolon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-4836) Default Pluto URL parser could not hanle semicolon in the parameter values

Posted by "Ivan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758106#action_12758106 ] 

Ivan commented on GERONIMO-4836:
--------------------------------

Go ahead to commit the changes to 2.2 At revision: 817485, so that we could have more time to do the testing, I will leave this JIRA open until Geronimo 2.2 is released.
The changes include:
a. fix semicolon in the parameter value
b. Use 0xz as the escape string for those special string
c. Remove the duplicate slash in the url, it may cause issues in Jetty build with compact attribute off.

> Default Pluto URL parser could not hanle semicolon in the parameter values
> --------------------------------------------------------------------------
>
>                 Key: GERONIMO-4836
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4836
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console, Tomcat
>    Affects Versions: 2.2
>            Reporter: Ivan
>             Fix For: 2.2
>
>
> While the input parameter contains semicolon, there will be some issues while handlering those parameters. Seem that Pluto would ignore those parameters after the semicolon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-4836) Default Pluto URL parser could not hanle semicolon in the parameter values

Posted by "Ivan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755024#action_12755024 ] 

Ivan commented on GERONIMO-4836:
--------------------------------

Yes, this class is configurable in the xml file, we could use our own in Geronimo.
I recreated a patch, and once it is accepted, I will do the change in Geronimo 2.2.
Thanks !

> Default Pluto URL parser could not hanle semicolon in the parameter values
> --------------------------------------------------------------------------
>
>                 Key: GERONIMO-4836
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4836
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console, Tomcat
>    Affects Versions: 2.2
>            Reporter: Ivan
>             Fix For: 2.2
>
>
> While the input parameter contains semicolon, there will be some issues while handlering those parameters. Seem that Pluto would ignore those parameters after the semicolon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-4836) Default Pluto URL parser could not hanle semicolon in the parameter values

Posted by "Ivan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan updated GERONIMO-4836:
---------------------------

    Summary: Default Pluto URL parser could not hanle semicolon in the parameter values  (was: A uniform way to handle semicolon in Tomcat/Pluto)

> Default Pluto URL parser could not hanle semicolon in the parameter values
> --------------------------------------------------------------------------
>
>                 Key: GERONIMO-4836
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4836
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console, Tomcat
>    Affects Versions: 2.2
>            Reporter: Ivan
>             Fix For: 2.2
>
>
> While the input parameter contains semicolon, there will be some issues while handlering those parameters. Seem that Pluto would ignore those parameters after the semicolon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.