You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/11 06:44:39 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #8464: [Schema] Multi version schema reader implementation.

sijie commented on a change in pull request #8464:
URL: https://github.com/apache/pulsar/pull/8464#discussion_r521144094



##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/GenericSchema.java
##########
@@ -40,17 +39,4 @@
      * @return generic record builder
      */
     GenericRecordBuilder newRecordBuilder();
-
-
-    static GenericSchema of(SchemaInfo schemaInfo) {

Review comment:
       You can't just remove methods from a public API because it will cause code incompatibility issues. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org