You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2016/01/27 06:37:34 UTC
Review Request 42845: Enable H2 logging to slf4j.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42845/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Repository: aurora
Description
-------
On a test cluster with DbTaskStore enabled there are several lines in the log that look like:
````
2016-01-26 13:07:14 jdbc[15]: exception
````
There is no other information with these lines. This is a result of setting `TRACE_LEVEL_SYSTEM_OUT` to `1` for H2. This will print out the error message but not the associated throwable: https://github.com/h2database/h2database/blob/a932268843ac84c7a665e427167ff2eb291d6b8e/h2/src/main/org/h2/message/TraceSystem.java#L228
The SLF4J implementation of tracing in H2 does not suffer from this restriction.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 36c462ac86cc605bd86bfc31c2f962a315099a02
src/main/resources/logback.xml faf0dbc94dea536a944be18810a7f330d4c94dee
Diff: https://reviews.apache.org/r/42845/diff/
Testing
-------
Set the level to debug initially and observed extra output in Vagrant.
Thanks,
Zameer Manji
Re: Review Request 42845: Enable H2 logging to slf4j.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42845/#review116634
-----------------------------------------------------------
Master (e2a973e) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 27, 2016, 9:38 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42845/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 9:38 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> On a test cluster with DbTaskStore enabled there are several lines in the log that look like:
> ````
> 2016-01-26 13:07:14 jdbc[15]: exception
> ````
> There is no other information with these lines. This is a result of setting `TRACE_LEVEL_SYSTEM_OUT` to `1` for H2. This will print out the error message but not the associated throwable: https://github.com/h2database/h2database/blob/a932268843ac84c7a665e427167ff2eb291d6b8e/h2/src/main/org/h2/message/TraceSystem.java#L228
>
> The SLF4J implementation of tracing in H2 does not suffer from this restriction.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 36c462ac86cc605bd86bfc31c2f962a315099a02
> src/main/resources/logback.xml faf0dbc94dea536a944be18810a7f330d4c94dee
>
> Diff: https://reviews.apache.org/r/42845/diff/
>
>
> Testing
> -------
>
> Set the level to debug initially and observed extra output in Vagrant.
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 42845: Enable H2 logging to slf4j.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42845/#review116630
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 27, 2016, 9:38 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42845/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 9:38 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> On a test cluster with DbTaskStore enabled there are several lines in the log that look like:
> ````
> 2016-01-26 13:07:14 jdbc[15]: exception
> ````
> There is no other information with these lines. This is a result of setting `TRACE_LEVEL_SYSTEM_OUT` to `1` for H2. This will print out the error message but not the associated throwable: https://github.com/h2database/h2database/blob/a932268843ac84c7a665e427167ff2eb291d6b8e/h2/src/main/org/h2/message/TraceSystem.java#L228
>
> The SLF4J implementation of tracing in H2 does not suffer from this restriction.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 36c462ac86cc605bd86bfc31c2f962a315099a02
> src/main/resources/logback.xml faf0dbc94dea536a944be18810a7f330d4c94dee
>
> Diff: https://reviews.apache.org/r/42845/diff/
>
>
> Testing
> -------
>
> Set the level to debug initially and observed extra output in Vagrant.
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 42845: Enable H2 logging to slf4j.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42845/
-----------------------------------------------------------
(Updated Jan. 27, 2016, 1:38 p.m.)
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Changes
-------
Bill's feedback.
Repository: aurora
Description
-------
On a test cluster with DbTaskStore enabled there are several lines in the log that look like:
````
2016-01-26 13:07:14 jdbc[15]: exception
````
There is no other information with these lines. This is a result of setting `TRACE_LEVEL_SYSTEM_OUT` to `1` for H2. This will print out the error message but not the associated throwable: https://github.com/h2database/h2database/blob/a932268843ac84c7a665e427167ff2eb291d6b8e/h2/src/main/org/h2/message/TraceSystem.java#L228
The SLF4J implementation of tracing in H2 does not suffer from this restriction.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 36c462ac86cc605bd86bfc31c2f962a315099a02
src/main/resources/logback.xml faf0dbc94dea536a944be18810a7f330d4c94dee
Diff: https://reviews.apache.org/r/42845/diff/
Testing
-------
Set the level to debug initially and observed extra output in Vagrant.
Thanks,
Zameer Manji
Re: Review Request 42845: Enable H2 logging to slf4j.
Posted by Zameer Manji <zm...@apache.org>.
> On Jan. 27, 2016, 10:41 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, lines 118-119
> > <https://reviews.apache.org/r/42845/diff/1/?file=1222489#file1222489line118>
> >
> > Please change this to explain that level 4 indicates intent to use slf4j, and change the link to
> > http://www.h2database.com/html/features.html#other_logging
Done.
> On Jan. 27, 2016, 10:41 a.m., Bill Farner wrote:
> > src/main/resources/logback.xml, line 21
> > <https://reviews.apache.org/r/42845/diff/1/?file=1222490#file1222490line21>
> >
> > This is really convenient! For those curious, it generates this output, essentially echoing the configuration:
> > ```
> > 18:36:36,988 |-INFO in ch.qos.logback.classic.LoggerContext[default] - Found resource [logback.xml] at [jar:file:/home/vagrant/aurora/dist/install/aurora-scheduler/lib/aurora-0.12
> > .0-SNAPSHOT.jar!/logback.xml]
> > 18:36:37,074 |-INFO in ch.qos.logback.core.joran.spi.ConfigurationWatchList@25af5db5 - URL [jar:file:/home/vagrant/aurora/dist/install/aurora-scheduler/lib/aurora-0.12.0-SNAPSHOT.
> > jar!/logback.xml] is not of type file
> > 18:36:37,356 |-INFO in ch.qos.logback.core.joran.action.AppenderAction - About to instantiate appender of type [ch.qos.logback.core.ConsoleAppender]
> > 18:36:37,366 |-INFO in ch.qos.logback.core.joran.action.AppenderAction - Naming appender as [STDERR]
> > 18:36:37,508 |-INFO in ch.qos.logback.core.joran.action.NestedComplexPropertyIA - Assuming default type [ch.qos.logback.classic.encoder.PatternLayoutEncoder] for [encoder] propert
> > y
> > 18:36:37,665 |-INFO in ch.qos.logback.classic.joran.action.RootLoggerAction - Setting level of ROOT logger to INFO
> > 18:36:37,669 |-INFO in ch.qos.logback.core.joran.action.AppenderRefAction - Attaching appender named [STDERR] to Logger[ROOT]
> > 18:36:37,672 |-INFO in ch.qos.logback.classic.joran.action.LoggerAction - Setting level of logger [h2database] to INFO
> > 18:36:37,672 |-INFO in ch.qos.logback.classic.joran.action.ConfigurationAction - End of configuration.
> > ```
Normally this output is only there if there is something to warn us about (ie more than one logback.xml file), however it is also good at confirming the logging configuration. Putting it at the top of log output ensures operators can confirm logging is configured as desired.
> On Jan. 27, 2016, 10:41 a.m., Bill Farner wrote:
> > src/main/resources/logback.xml, line 32
> > <https://reviews.apache.org/r/42845/diff/1/?file=1222490#file1222490line32>
> >
> > I believe you can omit this line, as it will inherit the root logger's appenders.
Done.
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42845/#review116604
-----------------------------------------------------------
On Jan. 26, 2016, 9:37 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42845/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 9:37 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> On a test cluster with DbTaskStore enabled there are several lines in the log that look like:
> ````
> 2016-01-26 13:07:14 jdbc[15]: exception
> ````
> There is no other information with these lines. This is a result of setting `TRACE_LEVEL_SYSTEM_OUT` to `1` for H2. This will print out the error message but not the associated throwable: https://github.com/h2database/h2database/blob/a932268843ac84c7a665e427167ff2eb291d6b8e/h2/src/main/org/h2/message/TraceSystem.java#L228
>
> The SLF4J implementation of tracing in H2 does not suffer from this restriction.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 36c462ac86cc605bd86bfc31c2f962a315099a02
> src/main/resources/logback.xml faf0dbc94dea536a944be18810a7f330d4c94dee
>
> Diff: https://reviews.apache.org/r/42845/diff/
>
>
> Testing
> -------
>
> Set the level to debug initially and observed extra output in Vagrant.
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 42845: Enable H2 logging to slf4j.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42845/#review116604
-----------------------------------------------------------
Ship it!
Fine to ship, suggested a bit of minor cleanup.
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java (lines 118 - 119)
<https://reviews.apache.org/r/42845/#comment177666>
Please change this to explain that level 4 indicates intent to use slf4j, and change the link to
http://www.h2database.com/html/features.html#other_logging
src/main/resources/logback.xml (line 21)
<https://reviews.apache.org/r/42845/#comment177674>
This is really convenient! For those curious, it generates this output, essentially echoing the configuration:
```
18:36:36,988 |-INFO in ch.qos.logback.classic.LoggerContext[default] - Found resource [logback.xml] at [jar:file:/home/vagrant/aurora/dist/install/aurora-scheduler/lib/aurora-0.12
.0-SNAPSHOT.jar!/logback.xml]
18:36:37,074 |-INFO in ch.qos.logback.core.joran.spi.ConfigurationWatchList@25af5db5 - URL [jar:file:/home/vagrant/aurora/dist/install/aurora-scheduler/lib/aurora-0.12.0-SNAPSHOT.
jar!/logback.xml] is not of type file
18:36:37,356 |-INFO in ch.qos.logback.core.joran.action.AppenderAction - About to instantiate appender of type [ch.qos.logback.core.ConsoleAppender]
18:36:37,366 |-INFO in ch.qos.logback.core.joran.action.AppenderAction - Naming appender as [STDERR]
18:36:37,508 |-INFO in ch.qos.logback.core.joran.action.NestedComplexPropertyIA - Assuming default type [ch.qos.logback.classic.encoder.PatternLayoutEncoder] for [encoder] propert
y
18:36:37,665 |-INFO in ch.qos.logback.classic.joran.action.RootLoggerAction - Setting level of ROOT logger to INFO
18:36:37,669 |-INFO in ch.qos.logback.core.joran.action.AppenderRefAction - Attaching appender named [STDERR] to Logger[ROOT]
18:36:37,672 |-INFO in ch.qos.logback.classic.joran.action.LoggerAction - Setting level of logger [h2database] to INFO
18:36:37,672 |-INFO in ch.qos.logback.classic.joran.action.ConfigurationAction - End of configuration.
```
src/main/resources/logback.xml (line 32)
<https://reviews.apache.org/r/42845/#comment177672>
I believe you can omit this line, as it will inherit the root logger's appenders.
- Bill Farner
On Jan. 26, 2016, 9:37 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42845/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 9:37 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> On a test cluster with DbTaskStore enabled there are several lines in the log that look like:
> ````
> 2016-01-26 13:07:14 jdbc[15]: exception
> ````
> There is no other information with these lines. This is a result of setting `TRACE_LEVEL_SYSTEM_OUT` to `1` for H2. This will print out the error message but not the associated throwable: https://github.com/h2database/h2database/blob/a932268843ac84c7a665e427167ff2eb291d6b8e/h2/src/main/org/h2/message/TraceSystem.java#L228
>
> The SLF4J implementation of tracing in H2 does not suffer from this restriction.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 36c462ac86cc605bd86bfc31c2f962a315099a02
> src/main/resources/logback.xml faf0dbc94dea536a944be18810a7f330d4c94dee
>
> Diff: https://reviews.apache.org/r/42845/diff/
>
>
> Testing
> -------
>
> Set the level to debug initially and observed extra output in Vagrant.
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 42845: Enable H2 logging to slf4j.
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 27, 2016, 9:56 a.m., Bill Farner wrote:
> > Are you sure this patch does what you want? When i apply the patch and run the scheduler in vagrant, the `h2database` logger shows as level `WARN` in `/logconfig`. When at level `DEBUG`, there is likely far more verbose you want - full SQL for every query, and reporting of calls to every JDBC API method call implemented by h2.
> > e.g. for a single task fetch:
> > ```
> > D0127 17:43:36.163 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
> > /**/conn6.getAutoCommit();
> > D0127 17:43:36.163 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
> > /**/conn6.getAutoCommit();
> > D0127 17:43:36.164 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
> > /**/conn6.commit();
> > D0127 17:43:36.164 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
> > /**/conn6.commit();
> > I0127 17:43:36.164 [AsyncProcessor-2, TraceWriterAdapter:66] jdbc[7]
> > /*SQL */COMMIT;
> > I0127 17:43:36.164 [AsyncProcessor-2, TraceWriterAdapter:66] jdbc[7]
> > /*SQL */COMMIT;
> > D0127 17:43:36.164 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
> > /**/conn6.getAutoCommit();
> > I0127 17:43:36.164 [TaskReconciler-0, TraceWriterAdapter:66] jdbc[6]
> > /*SQL l:124 #:1 t:685*/SELECT\n id,\n name,\n port\n FROM task_ports\n WHERE task_row_id = (SELECT id FROM tasks WHERE task_id = ?) {1: '1453916569060-vagrant
> > -test-http_example-1-3a77ea53-59cf-424b-9c1e-6ac15bfd3b64'};
> > D0127 17:43:36.164 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
> > /**/conn6.getAutoCommit();
> > I0127 17:43:36.164 [TaskReconciler-0, TraceWriterAdapter:66] jdbc[6]
> > /*SQL l:124 #:1 t:685*/SELECT\n id,\n name,\n port\n FROM task_ports\n WHERE task_row_id = (SELECT id FROM tasks WHERE task_id = ?) {1: '1453916569060-vagrant
> > -test-http_example-1-3a77ea53-59cf-424b-9c1e-6ac15bfd3b64'};
> > D0127 17:43:36.165 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
> > /**/conn6.setAutoCommit(true);
> > D0127 17:43:36.165 [TaskReconciler-0, TraceWriterAdapter:63] jdbc[6]
> > /**/ResultSet rs6250 = prep5733.getResultSet();
> > I0127 17:43:36.165 [SlaStat-0, TraceWriterAdapter:66] jdbc[10]
> > /*SQL l:124 #:1 t:98*/SELECT\n id,\n name,\n port\n FROM task_ports\n WHERE task_row_id = (SELECT id FROM tasks WHERE task_id = ?) {1: '1453843867483-vagrant-test-http_example_docker-0-ae563d91-5960-416d-95ac-156990334ff4'};
> > D0127 17:43:36.165 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
> > /**/conn6.setAutoCommit(true);
> > D0127 17:43:36.165 [TaskReconciler-0, TraceWriterAdapter:63] jdbc[6]
> > /**/ResultSet rs6250 = prep5733.getResultSet();
> > I0127 17:43:36.165 [SlaStat-0, TraceWriterAdapter:66] jdbc[10]
> > /*SQL l:124 #:1 t:98*/SELECT\n id,\n name,\n port\n FROM task_ports\n WHERE task_row_id = (SELECT id FROM tasks WHERE task_id = ?) {1: '1453843867483-vagrant-test-http_example_docker-0-ae563d91-5960-416d-95ac-156990334ff4'};
> > D0127 17:43:36.166 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
> > /**/conn6.commit();
> > ```
Please ignore the above - the convoluted knobs in h2 to enable this mode threw me. Taking another look.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42845/#review116602
-----------------------------------------------------------
On Jan. 26, 2016, 9:37 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42845/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 9:37 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> On a test cluster with DbTaskStore enabled there are several lines in the log that look like:
> ````
> 2016-01-26 13:07:14 jdbc[15]: exception
> ````
> There is no other information with these lines. This is a result of setting `TRACE_LEVEL_SYSTEM_OUT` to `1` for H2. This will print out the error message but not the associated throwable: https://github.com/h2database/h2database/blob/a932268843ac84c7a665e427167ff2eb291d6b8e/h2/src/main/org/h2/message/TraceSystem.java#L228
>
> The SLF4J implementation of tracing in H2 does not suffer from this restriction.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 36c462ac86cc605bd86bfc31c2f962a315099a02
> src/main/resources/logback.xml faf0dbc94dea536a944be18810a7f330d4c94dee
>
> Diff: https://reviews.apache.org/r/42845/diff/
>
>
> Testing
> -------
>
> Set the level to debug initially and observed extra output in Vagrant.
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 42845: Enable H2 logging to slf4j.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42845/#review116602
-----------------------------------------------------------
Are you sure this patch does what you want? When i apply the patch and run the scheduler in vagrant, the `h2database` logger shows as level `WARN` in `/logconfig`. When at level `DEBUG`, there is likely far more verbose you want - full SQL for every query, and reporting of calls to every JDBC API method call implemented by h2.
e.g. for a single task fetch:
```
D0127 17:43:36.163 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
/**/conn6.getAutoCommit();
D0127 17:43:36.163 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
/**/conn6.getAutoCommit();
D0127 17:43:36.164 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
/**/conn6.commit();
D0127 17:43:36.164 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
/**/conn6.commit();
I0127 17:43:36.164 [AsyncProcessor-2, TraceWriterAdapter:66] jdbc[7]
/*SQL */COMMIT;
I0127 17:43:36.164 [AsyncProcessor-2, TraceWriterAdapter:66] jdbc[7]
/*SQL */COMMIT;
D0127 17:43:36.164 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
/**/conn6.getAutoCommit();
I0127 17:43:36.164 [TaskReconciler-0, TraceWriterAdapter:66] jdbc[6]
/*SQL l:124 #:1 t:685*/SELECT\n id,\n name,\n port\n FROM task_ports\n WHERE task_row_id = (SELECT id FROM tasks WHERE task_id = ?) {1: '1453916569060-vagrant
-test-http_example-1-3a77ea53-59cf-424b-9c1e-6ac15bfd3b64'};
D0127 17:43:36.164 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
/**/conn6.getAutoCommit();
I0127 17:43:36.164 [TaskReconciler-0, TraceWriterAdapter:66] jdbc[6]
/*SQL l:124 #:1 t:685*/SELECT\n id,\n name,\n port\n FROM task_ports\n WHERE task_row_id = (SELECT id FROM tasks WHERE task_id = ?) {1: '1453916569060-vagrant
-test-http_example-1-3a77ea53-59cf-424b-9c1e-6ac15bfd3b64'};
D0127 17:43:36.165 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
/**/conn6.setAutoCommit(true);
D0127 17:43:36.165 [TaskReconciler-0, TraceWriterAdapter:63] jdbc[6]
/**/ResultSet rs6250 = prep5733.getResultSet();
I0127 17:43:36.165 [SlaStat-0, TraceWriterAdapter:66] jdbc[10]
/*SQL l:124 #:1 t:98*/SELECT\n id,\n name,\n port\n FROM task_ports\n WHERE task_row_id = (SELECT id FROM tasks WHERE task_id = ?) {1: '1453843867483-vagrant-test-http_example_docker-0-ae563d91-5960-416d-95ac-156990334ff4'};
D0127 17:43:36.165 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
/**/conn6.setAutoCommit(true);
D0127 17:43:36.165 [TaskReconciler-0, TraceWriterAdapter:63] jdbc[6]
/**/ResultSet rs6250 = prep5733.getResultSet();
I0127 17:43:36.165 [SlaStat-0, TraceWriterAdapter:66] jdbc[10]
/*SQL l:124 #:1 t:98*/SELECT\n id,\n name,\n port\n FROM task_ports\n WHERE task_row_id = (SELECT id FROM tasks WHERE task_id = ?) {1: '1453843867483-vagrant-test-http_example_docker-0-ae563d91-5960-416d-95ac-156990334ff4'};
D0127 17:43:36.166 [AsyncProcessor-2, TraceWriterAdapter:63] jdbc[7]
/**/conn6.commit();
```
- Bill Farner
On Jan. 26, 2016, 9:37 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42845/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 9:37 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> On a test cluster with DbTaskStore enabled there are several lines in the log that look like:
> ````
> 2016-01-26 13:07:14 jdbc[15]: exception
> ````
> There is no other information with these lines. This is a result of setting `TRACE_LEVEL_SYSTEM_OUT` to `1` for H2. This will print out the error message but not the associated throwable: https://github.com/h2database/h2database/blob/a932268843ac84c7a665e427167ff2eb291d6b8e/h2/src/main/org/h2/message/TraceSystem.java#L228
>
> The SLF4J implementation of tracing in H2 does not suffer from this restriction.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 36c462ac86cc605bd86bfc31c2f962a315099a02
> src/main/resources/logback.xml faf0dbc94dea536a944be18810a7f330d4c94dee
>
> Diff: https://reviews.apache.org/r/42845/diff/
>
>
> Testing
> -------
>
> Set the level to debug initially and observed extra output in Vagrant.
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 42845: Enable H2 logging to slf4j.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42845/#review116545
-----------------------------------------------------------
Master (9faec2f) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 27, 2016, 5:37 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42845/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 5:37 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> On a test cluster with DbTaskStore enabled there are several lines in the log that look like:
> ````
> 2016-01-26 13:07:14 jdbc[15]: exception
> ````
> There is no other information with these lines. This is a result of setting `TRACE_LEVEL_SYSTEM_OUT` to `1` for H2. This will print out the error message but not the associated throwable: https://github.com/h2database/h2database/blob/a932268843ac84c7a665e427167ff2eb291d6b8e/h2/src/main/org/h2/message/TraceSystem.java#L228
>
> The SLF4J implementation of tracing in H2 does not suffer from this restriction.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 36c462ac86cc605bd86bfc31c2f962a315099a02
> src/main/resources/logback.xml faf0dbc94dea536a944be18810a7f330d4c94dee
>
> Diff: https://reviews.apache.org/r/42845/diff/
>
>
> Testing
> -------
>
> Set the level to debug initially and observed extra output in Vagrant.
>
>
> Thanks,
>
> Zameer Manji
>
>