[GitHub] [incubator-nemo] DifferentSC commented on a change in pull request #206: [NEMO-369] DirectByteArrayOutputStream usage refactoring

[GitBox <gi...@apache.org>]

DifferentSC commented on a change in pull request #206: [NEMO-369] DirectByteArrayOutputStream usage refactoring
URL: https://github.com/apache/incubator-nemo/pull/206#discussion_r268626798
 
 

 ##########
 File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/DataUtil.java
 ##########
 @@ -119,8 +119,9 @@ private static void serializePartition(final EncoderFactory encoderFactory,
         // We need to close wrappedStream on here, because DirectByteArrayOutputStream:getBufDirectly() returns
         // inner buffer directly, which can be an unfinished(not flushed) buffer.
         wrappedStream.close();
+        // Note that serializedBytes include invalid bytes. So we have to use it with the actualLength whenever needed
 
 Review comment:
   +1 for this comment. @hy00nc Could you add this comment to `getBufDirectly()` in `DirectByteArrayOutputStream`, too? Maybe we can also add todo like `// TODO: [NEMO-370] ...`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services