[GitHub] [fineract] rrpawar96 commented on pull request #2190: FINERACT-1431:ClientIdentifierPassportCountries

[GitBox <gi...@apache.org>]

rrpawar96 commented on PR #2190:
URL: https://github.com/apache/fineract/pull/2190#issuecomment-1124365672

   @francisguchie, @galovics  Apologies for the late.
   @galovics, Comments have been addressed and now the properties of countries are getting loaded while booting.
   I have done a small twist I have removed the country code from database and providing the country code and country name to user from properties file itself.
   So it goes like this: 
   1. when the user fetches the country list from code value API, it provides countries list (along with country code) from properties file (getCountriesList() function- loaded in startup)
   2. when the user selects country and saves in the identifier, country-code gets saved. and when the user fetches this identifier, the country-code gets translated to country name. (translateCountryList() function - loaded in startup)
   So only country which is saved in identifier is getting translated instead of translating whole country list (which would have been required in step (1) but now its not,  and loading the properties file and the translation at startup time.
   Let me know, if it is ok with this way.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org