You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/15 06:47:33 UTC
[GitHub] liuxianjiao commented on a change in pull request #6612:
[FLINK-10215]Add configuration of java option for historyserver
liuxianjiao commented on a change in pull request #6612: [FLINK-10215]Add configuration of java option for historyserver
URL: https://github.com/apache/flink/pull/6612#discussion_r217877944
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -140,6 +140,10 @@
.key("env.java.opts.taskmanager")
.defaultValue("");
+ public static final ConfigOption<String> FLINK_HS_JVM_OPTIONS = ConfigOptions
+ .key("env.java.opts.historyserver")
+ .defaultValue("");
Review comment:
@tillrohrmann Thanks for your review. As for the description， I think the annotation "process parameters" in line 128 of this class already has described “FLINK_JVM_OPTIONS”，“FLINK_JM_JVM_OPTIONS”，“FLINK_TM_JVM_OPTIONS”，as well as our “FLINK_HS_JVM_OPTIONS”.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services