You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by ky...@apache.org on 2018/06/26 10:15:26 UTC
incubator-weex git commit: * [Android] Fix potential memory leak.
Repository: incubator-weex
Updated Branches:
refs/heads/master e82a37236 -> 361df724c
* [Android] Fix potential memory leak.
Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/361df724
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/361df724
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/361df724
Branch: refs/heads/master
Commit: 361df724c5250dcaa2eb196836c2e38dfe6477a6
Parents: e82a372
Author: YorkShen <sh...@gmail.com>
Authored: Tue Jun 26 17:54:36 2018 +0800
Committer: YorkShen <sh...@gmail.com>
Committed: Tue Jun 26 18:15:07 2018 +0800
----------------------------------------------------------------------
.../sdk/src/main/java/com/taobao/weex/bridge/WXModuleManager.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/361df724/android/sdk/src/main/java/com/taobao/weex/bridge/WXModuleManager.java
----------------------------------------------------------------------
diff --git a/android/sdk/src/main/java/com/taobao/weex/bridge/WXModuleManager.java b/android/sdk/src/main/java/com/taobao/weex/bridge/WXModuleManager.java
index c13a442..83aa0b0 100644
--- a/android/sdk/src/main/java/com/taobao/weex/bridge/WXModuleManager.java
+++ b/android/sdk/src/main/java/com/taobao/weex/bridge/WXModuleManager.java
@@ -30,6 +30,7 @@ import com.taobao.weex.adapter.IWXUserTrackAdapter;
import com.taobao.weex.common.Destroyable;
import com.taobao.weex.common.WXErrorCode;
import com.taobao.weex.common.WXException;
+import com.taobao.weex.common.WXInstanceWrap;
import com.taobao.weex.common.WXModule;
import com.taobao.weex.ui.config.ConfigModuleFactory;
import com.taobao.weex.ui.module.WXDomModule;
@@ -183,7 +184,7 @@ public class WXModuleManager {
WXLogUtils.e("callModuleMethod >>> invoke module:" + moduleStr + ", method:" + methodStr + " failed. ", e);
return null;
} finally {
- if (wxModule instanceof WXDomModule || wxModule instanceof WXTimerModule) {
+ if (wxModule instanceof WXDomModule || wxModule instanceof WXTimerModule || wxModule instanceof WXInstanceWrap) {
wxModule.mWXSDKInstance = null;
}
}