[GitHub] [cloudstack] ravening commented on a change in pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

[GitBox <gi...@apache.org>]

ravening commented on a change in pull request #5233:
URL: https://github.com/apache/cloudstack/pull/5233#discussion_r674665625



##########
File path: ui/src/config/section/compute.js
##########
@@ -299,7 +299,7 @@ export default {
           docHelp: 'adminguide/virtual_machines.html#how-to-dynamically-scale-cpu-and-ram',
           dataView: true,
           show: (record) => { return ['Stopped'].includes(record.state) || (['Running'].includes(record.state) && record.hypervisor !== 'KVM' && record.hypervisor !== 'LXC') },
-          disabled: (record) => { return !record.isdynamicallyscalable },
+          disabled: (record) => { return !record.isdynamicallyscalable && record.state !== 'Stopped' },

Review comment:
       > Maybe
   > `disabled: (record) => { return record.state === 'Running' && !record.isdynamicallyscalable }`
   
   but isnt `record.state !== 'Stopped'` and `record.state === 'Running' ` are same?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org