You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "rahulgoswami (via GitHub)" <gi...@apache.org> on 2026/10/19 01:43:02 UTC

[PR] Document cuvs solr10.1 breakage [solr]

rahulgoswami opened a new pull request, #5182:
URL: https://github.com/apache/solr/pull/5182

   https://issues.apache.org/jira/browse/SOLR-18556 
   
   <!--
   _(If you are a project committer then you may remove some/all of the following template.)_
   
   Before creating a pull request, please file an issue in the ASF Jira system for Solr:
   
   * https://issues.apache.org/jira/projects/SOLR
   
   For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
   To create a Jira issue, you will need to create an account there first.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * SOLR-####: <short description of problem or changes>
   
   SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
   
   
   # Description
   
   Please provide a short description of the changes you're making with this pull request.
   
   # Solution
   
   Please provide a short description of the approach taken to implement your solution.
   We appreciate transparent disclosure of significant [AI Coding assistants](https://github.com/apache/solr/blob/main/dev-docs/how-to-contribute.adoc#setup-for-contributing) usage.
   
   # Tests
   
   Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request title.
   - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
   - [ ] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   - [ ] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Document cuvs module breakage in Solr 10.1 [solr]

Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #5182:
URL: https://github.com/apache/solr/pull/5182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Document cuvs module breakage in Solr 10.1 [solr]

Posted by "rahulgoswami (via GitHub)" <gi...@apache.org>.
rahulgoswami commented on PR #5182:
URL: https://github.com/apache/solr/pull/5182#issuecomment-6272212983

   > Looks fine. Maybe reference your jira "for updates"? Also don't want to suggest that you can fix things yourself whe t why make their release?
   
   @epugh  Thanks for taking a look. I thought about your suggestion but feel it might be "safer" to suggest to the users to just wait out a release instead of us promising a drop-in replacement of the library to work without tests running on Solr 10.1. What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Document cuvs module breakage in Solr 10.1 [solr]

Posted by "rahulgoswami (via GitHub)" <gi...@apache.org>.
rahulgoswami commented on PR #5182:
URL: https://github.com/apache/solr/pull/5182#issuecomment-6258268401

   @chatman  requesting a doc review please.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Document cuvs module breakage in Solr 10.1 [solr]

Posted by "rahulgoswami (via GitHub)" <gi...@apache.org>.
rahulgoswami commented on code in PR #5182:
URL: https://github.com/apache/solr/pull/5182#discussion_r4316362819


##########
solr/solr-ref-guide/modules/query-guide/pages/dense-vector-search.adoc:
##########
@@ -1042,6 +1042,14 @@ Details about using the ReRank Query Parser can be found in the xref:query-guide
 [NOTE]
 This is feature is currently experimental.
 
+[WARNING]
+====
+Vector indexing with GPU acceleration does not work in Solr 10.1 (SOLR-18556), because the bundled cuVS-Lucene library (25.12) is not compatible with Lucene 10.4.
+If you use GPU acceleration, skip Solr 10.1 and stay on Solr 10.0.x.

Review Comment:
   @sigram  Thanks for taking a look. I have made some changes to remove duplication.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Document cuvs module breakage in Solr 10.1 [solr]

Posted by "sigram (via GitHub)" <gi...@apache.org>.
sigram commented on code in PR #5182:
URL: https://github.com/apache/solr/pull/5182#discussion_r4312494555


##########
solr/solr-ref-guide/modules/query-guide/pages/dense-vector-search.adoc:
##########
@@ -1042,6 +1042,14 @@ Details about using the ReRank Query Parser can be found in the xref:query-guide
 [NOTE]
 This is feature is currently experimental.
 
+[WARNING]
+====
+Vector indexing with GPU acceleration does not work in Solr 10.1 (SOLR-18556), because the bundled cuVS-Lucene library (25.12) is not compatible with Lucene 10.4.
+If you use GPU acceleration, skip Solr 10.1 and stay on Solr 10.0.x.

Review Comment:
   I think we can skip 1048-1049 because we already point to the major changes doc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org