You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/30 17:06:15 UTC
[GitHub] [camel-website] zregvart commented on a change in pull request
#271: Fixes Wastage of screen real-estate on large displays
zregvart commented on a change in pull request #271: Fixes Wastage of screen real-estate on large displays
URL: https://github.com/apache/camel-website/pull/271#discussion_r400352393
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -130,10 +130,10 @@
--nav-panel-height: calc(var(--nav-height) - var(--drawer-height));
--nav-panel-height--desktop: calc(var(--nav-height--desktop) - var(--drawer-height));
--nav-width: calc(270 / var(--rem-base) * 1rem);
- --doc-max-width: calc(720 / var(--rem-base) * 1rem);
- --doc-max-width--desktop: calc(828 / var(--rem-base) * 1rem);
- --static-max-width: calc(720 / var(--rem-base) * 1rem);
- --static-max-width--desktop: calc(1140 / var(--rem-base) * 1rem);
+ --doc-max-width: 81vw;
+ --doc-max-width--desktop: 64vw;
+ --static-max-width: 81vw;
+ --static-max-width--desktop: 88vw;
Review comment:
Previously we had this based on screen resolutions and the rem unit, not sure where these numbers come from, can you explain them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services