You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/11 05:19:08 UTC

[GitHub] [skywalking] vcjmhg commented on a change in pull request #5987: Fix logger-plugin module directory structure problem(Maven cannot trigger junit testing).

vcjmhg commented on a change in pull request #5987:
URL: https://github.com/apache/skywalking/pull/5987#discussion_r540696621



##########
File path: apm-sniffer/optional-plugins/logger-plugin/src/test/java/org/apache/skywalking/apm/plugin/logger/ContextConfigDefaultTest.java
##########
@@ -24,7 +25,7 @@
 public class ContextConfigDefaultTest {
     @Test
     public void testDefaultConfig() {
-        ContextConfig config = ContextConfig.getInstance();
+        ContextConfig config = ContextConfig.getLatestConfig();

Review comment:
       @zifeihan Why we should write another method named `getLastsConfig()` for UT. It seems that when any UT starts, `initContextConfig()` will be executed. Just curious :smile: 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org