You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/19 03:15:07 UTC
[GitHub] [spark] panbingkun opened a new pull request, #39119: [SPARK-41568][SQL] Assign name to _LEGACY_ERROR_TEMP_1236
panbingkun opened a new pull request, #39119:
URL: https://github.com/apache/spark/pull/39119
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #39119: [SPARK-41568][SQL] Assign name to _LEGACY_ERROR_TEMP_1236
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #39119: [SPARK-41568][SQL] Assign name to _LEGACY_ERROR_TEMP_1236
URL: https://github.com/apache/spark/pull/39119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39119: [SPARK-41568][SQL] Assign name to _LEGACY_ERROR_TEMP_1236
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #39119:
URL: https://github.com/apache/spark/pull/39119#discussion_r1053163693
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1309,6 +1309,11 @@
"The ANALYZE TABLE FOR COLUMNS command does not support the type <columnType> of the column <columnName> in the table <tableName>."
]
},
+ "ANALYZE_VIEW" : {
+ "message" : [
+ "The ANALYZE TABLE command does not supported on views."
Review Comment:
```suggestion
"The ANALYZE TABLE command does not support views."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #39119: [SPARK-41568][SQL] Assign name to _LEGACY_ERROR_TEMP_1236
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #39119:
URL: https://github.com/apache/spark/pull/39119#issuecomment-1359947772
+1, LGTM. Merging to master.
Thank you, @panbingkun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #39119: [SPARK-41568][SQL] Assign name to _LEGACY_ERROR_TEMP_1236
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #39119:
URL: https://github.com/apache/spark/pull/39119#issuecomment-1360867062
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org