You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@helix.apache.org by "kishore gopalakrishna (JIRA)" <ji...@apache.org> on 2013/05/23 00:08:20 UTC

[jira] [Commented] (HELIX-113) Code cleanup for helix cluster auto-join mode

    [ https://issues.apache.org/jira/browse/HELIX-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664600#comment-13664600 ] 

kishore gopalakrishna commented on HELIX-113:
---------------------------------------------

The following log gets printed when auto-join is turned on.

2013-05-22 20:01:19,521 INFO org.apache.helix.manager.zk.ZKUtil: Invalid instance setup, missing znode path: /MYCLUSTER/CONFIGS/PARTICIPANT/eat1-hcl4987.grid.linkedin.com_37424
2013-05-22 20:01:19,564 INFO org.apache.helix.manager.zk.ZKUtil: Invalid instance setup, missing znode path: /MYCLUSTER/INSTANCES/eat1-hcl4987.grid.linkedin.com_37424/MESSAGES
2013-05-22 20:01:19,607 INFO org.apache.helix.manager.zk.ZKUtil: Invalid instance setup, missing znode path: /MYCLUSTER/INSTANCES/eat1-hcl4987.grid.linkedin.com_37424/CURRENTSTATES
2013-05-22 20:01:19,650 INFO org.apache.helix.manager.zk.ZKUtil: Invalid instance setup, missing znode path: /MYCLUSTER/INSTANCES/eat1-hcl4987.grid.linkedin.com_37424/STATUSUPDATES
2013-05-22 20:01:19,694 INFO org.apache.helix.manager.zk.ZKUtil: Invalid instance setup, missing znode path: /MYCLUSTER/INSTANCES/eat1-hcl4987.grid.linkedin.com_37424/ERRORS
2013-05-22 20:01:19,694 INFO org.apache.helix.manager.zk.ZKHelixManager: Auto joining instance eat1-hcl4987.grid.linkedin.com_37424
2013-05-22 20:01:20,547 INFO org.apache.helix.manager.zk.CallbackHandler: 26 START:INVOKE /MYCLUSTER/CONFIGS/PARTICIPANT listener:org.apache.helix.controller.GenericHelixController

missing znode path statement should not appear when auto-join is turned on.

ALLOW_PARTICIPANT_AUTO_JOIN = "allowParticipantAutoJoin";

Other things to fix. 
1.   Constant is declared in zkhelixmanager. There should be separate Enum class that defines all clusterconfigs, instanceconfigs that Helix understands.
2. String representing the enum should generally be the same. 
3. Allow the flag to be overwritten while joining, we will need this as part of new Participant class that we plan to add as part of 0.6.2.
                
   

                
> Code cleanup for helix cluster auto-join mode 
> ----------------------------------------------
>
>                 Key: HELIX-113
>                 URL: https://issues.apache.org/jira/browse/HELIX-113
>             Project: Apache Helix
>          Issue Type: Task
>            Reporter: Shi Lu
>            Assignee: Shi Lu
>             Fix For: 0.6.2-incubating
>
>
> Need to cleanup the helix cluster auto-join mode string constants and add documentation for it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira