[GitHub] Tibor17 commented on issue #185: [SUREFIRE-1522] fix escapeBytesToPrintable bounds check

[GitBox <gi...@apache.org>]

Tibor17 commented on issue #185: [SUREFIRE-1522] fix escapeBytesToPrintable bounds check
URL: https://github.com/apache/maven-surefire/pull/185#issuecomment-389987091
 
 
   @docrjp Great job! I want it but there is a problem with your checkstyle error because you did not run the build `mvn install`. Simply fix `off+len` and use white space `off + len`. Override the commit with `git amend`.
   
   This is the error from build log:
   ```
   [INFO] --- maven-checkstyle-plugin:2.15:check (checkstyle-check) @ surefire-api ---
   [INFO] There are 2 errors reported by Checkstyle 6.1.1 with config/maven_checks.xml ruleset.
   [ERROR] src\main\java\org\apache\maven\surefire\util\internal\StringUtils.java[246:84] (whitespace) WhitespaceAround: '+' is not preceded with whitespace.
   [ERROR] src\main\java\org\apache\maven\surefire\util\internal\StringUtils.java[246:85] (whitespace) WhitespaceAround: '+' is not followed by whitespace.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services